Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 784d018fbec56db6387fd59aea1e060471f85706
https://github.com/WebKit/WebKit/commit/784d018fbec56db6387fd59aea1e060471f85706
Author: Alex Christensen <[email protected]>
Date: 2026-07-07 (Tue, 07 Jul 2026)
Changed paths:
M Source/WebCore/animation/WebAnimationTypes.h
M Source/WebCore/platform/animation/AcceleratedEffect.cpp
M Source/WebKit/Scripts/generate-serializers.py
M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAnimationUtilities.cpp
Log Message:
-----------
Add warning when OptionSet enum values are missing in serialization.in files
https://bugs.webkit.org/show_bug.cgi?id=318703
rdar://181517451
Reviewed by Antoine Quint.
After 316565@main only one value was missing:
AcceleratedEffectProperty::Invalid, which
is actually not needed at all. Make acceleratedPropertyFromCSSProperty return
an OptionSet
so we can return an empty set instead of a value in the theoretically
impossible case.
WebCore::ScrollingStateNodeProperty has a few duplicate values, but that needs
to stay,
so I left the values as comments. The generator now makes an empty switch
statement
to make a warning if we've missed a value to protect against future mistakes.
* Source/WebCore/animation/WebAnimationTypes.h:
* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::acceleratedPropertyFromCSSProperty):
(WebCore::AcceleratedEffect::AcceleratedEffect):
(WebCore::blend):
* Source/WebKit/Scripts/generate-serializers.py:
(generate_impl):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(WTF::isValidOptionSet<EnumNamespace2::OptionSetEnumType>):
(WTF::isValidOptionSet<OptionSetEnumFirstCondition>):
(WTF::isValidOptionSet<OptionSetEnumLastCondition>):
(WTF::isValidOptionSet<OptionSetEnumAllCondition>):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAnimationUtilities.cpp:
(WebKit::toStringForTesting):
Canonical link: https://commits.webkit.org/316630@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
