Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d147fb1fbc37a2d39eff92e5661ef37c6fecc0fb
https://github.com/WebKit/WebKit/commit/d147fb1fbc37a2d39eff92e5661ef37c6fecc0fb
Author: Simon Fraser <[email protected]>
Date: 2026-07-07 (Tue, 07 Jul 2026)
Changed paths:
R
LayoutTests/fast/scrolling/always-on-scrollbar-dark-appearance-expected.html
R LayoutTests/fast/scrolling/always-on-scrollbar-dark-appearance.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/ScrollableArea.cpp
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
Log Message:
-----------
REGRESSION (312300@main) Main frame scrollbars to disappear on light-themed
pages with dark backgrounds
https://bugs.webkit.org/show_bug.cgi?id=318737
rdar://180346137
Unreviewed revert.
After 312300@main, legacy scrollbars in a light themed page with a dark
background were in light mode,
causing them to be invisible.
The original change missed the fact that in iframes we clip the content area to
the inside of
the scrollbars, so they are always rendering over the iframe background (which
may be transparent),
but main frame scrollbars render over the `documentBackgroundColor()`, so need
the color-based
`scrollbarOverlayStyle()` logic (which is misleadingly named when called for
always-on scrollbars).
There are existing issues with always-on iframe scrollbar which will take more
work to address;
we don't paint a background behind them unlike other browsers, and probably
should.
* LayoutTests/fast/scrolling/always-on-scrollbar-dark-appearance-expected.html:
Removed.
* LayoutTests/fast/scrolling/always-on-scrollbar-dark-appearance.html: Removed.
* Source/WebCore/platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::useDarkAppearanceForScrollbars const):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::useDarkAppearance const): Deleted.
Canonical link: https://commits.webkit.org/316635@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
