Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1700c91c45be0cdbe00ef2f759d610fd2ec37c17
https://github.com/WebKit/WebKit/commit/1700c91c45be0cdbe00ef2f759d610fd2ec37c17
Author: Basuke Suzuki <[email protected]>
Date: 2026-07-07 (Tue, 07 Jul 2026)
Changed paths:
M Tools/TestWebKitAPI/PlatformMac.cmake
Log Message:
-----------
[CMake] TestWebKitAPI build broken: ISOBMFFTrackInfoParserTests.cpp not added
to CMake source list
https://bugs.webkit.org/show_bug.cgi?id=318787
Unreviewed build fix.
Commit 316626@main added the ISOBMFFTrackInfoParser source files and the
ISOBMFFTrackInfoParserTests.cpp API test, but only registered them in the
Xcode projects. Two things were missing from the CMake build:
- The test file was registered in the Xcode project as a
membershipException (compiled outside unified sources), but was not
added to the matching non-unified source list in PlatformMac.cmake, so
it was not built by CMake.
- ISOBMFFTrackInfoParser.h was marked Private in the Xcode project but
was not added to WebCore's exported framework headers, so
<WebCore/ISOBMFFTrackInfoParser.h> could not be resolved from
TestWebKitAPI.
* Source/WebCore/PlatformCocoa.cmake: Export ISOBMFFTrackInfoParser.h as
a WebCore private framework header.
* Tools/TestWebKitAPI/PlatformMac.cmake: Build ISOBMFFTrackInfoParserTests.cpp
as a non-unified source, matching its Xcode membershipException.
Canonical link: https://commits.webkit.org/316655@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
