Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aaf1bb8a51dc510c7c95a5f63067024d191b99fe
https://github.com/WebKit/WebKit/commit/aaf1bb8a51dc510c7c95a5f63067024d191b99fe
Author: Sammy Gill <[email protected]>
Date: 2026-07-07 (Tue, 07 Jul 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-below-container-is-painted-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-below-container-is-painted-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-below-container-is-painted.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-both-axes-is-painted-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-both-axes-is-painted-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-both-axes-is-painted.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-nonstart-cell-is-painted-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-nonstart-cell-is-painted-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-nonstart-cell-is-painted.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-right-of-container-is-painted-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-right-of-container-is-painted-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-right-of-container-is-painted.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-multiple-items-are-painted-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-multiple-items-are-painted-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-multiple-items-are-painted.html
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridLayout.cpp
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridLayout.h
M Source/WebCore/rendering/RenderGrid.cpp
Log Message:
-----------
[GFC] Visually overflowing content may not get painted in certain
circumstances.
https://bugs.webkit.org/show_bug.cgi?id=318489
rdar://problem/181277780
Reviewed by Alan Baradlay.
RenderBlock::paint has an early return that will exit the function if
the visual content is clipped out with respect to the painting rect.
This is done by checking to see if the visual overflow rect intersects
with the painting rect. In the scenario where there is no visual
overflow visualOverflowRect() will just return the border box rect of
the renderer.
Currently, we do not report any sort of visual overflow for GFC content
so RenderBlock::paint always grabs the border box rect. In the cases
where the border box rect has a width of height is 0, since intersects()
checks for empty rects, we end up early returning even if the grid has
visual content.
We can fix this by collecting any sort of visual overflow at the end of
layout inside of integration and set it on the RenderGrid if there is
any.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-below-container-is-painted.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-both-axes-is-painted.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-in-nonstart-cell-is-painted.html:
Added.
Checks to make sure that we still properly report visual overflow if the
overflowing content does not start at the content box origin of the grid.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-item-right-of-container-is-painted.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-overflowing-multiple-items-are-painted.html:
Added.
Canonical link: https://commits.webkit.org/316668@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
