Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a69b24040c7a7b89336307285d1a4ddd306a2531
https://github.com/WebKit/WebKit/commit/a69b24040c7a7b89336307285d1a4ddd306a2531
Author: Tim Nguyen <[email protected]>
Date: 2026-07-07 (Tue, 07 Jul 2026)
Changed paths:
M
LayoutTests/fast/forms/select/base/option-focus-visible-outline-offset-expected.txt
M
LayoutTests/fast/forms/select/base/option-focus-visible-outline-offset.html
A
LayoutTests/fast/forms/select/base/option-inset-outline-offset-expected.txt
A LayoutTests/fast/forms/select/base/option-inset-outline-offset.html
R
LayoutTests/fast/forms/select/base/option-internal-inset-outline-offset-expected.txt
R
LayoutTests/fast/forms/select/base/option-internal-inset-outline-offset.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-001-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-002-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-002-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-002.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-003-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-003-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-003.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-004-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-004-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-004.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-005-expected.xht
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-005.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-006-expected-mismatch.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-006-notref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-006.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-invalid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-invalid.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-valid.html
M
LayoutTests/platform/ios/fast/forms/select/base/option-focus-visible-outline-offset-expected.txt
A
LayoutTests/platform/ios/fast/forms/select/base/option-inset-outline-offset-expected.txt
R
LayoutTests/platform/ios/fast/forms/select/base/option-internal-inset-outline-offset-expected.txt
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/html.css
M Source/WebCore/style/StyleExtractorCustom.h
M Source/WebCore/style/computed/StyleComputedStyle.cpp
M Source/WebCore/style/computed/StyleComputedStyle.h
M Source/WebCore/style/values/outline/StyleOutlineOffset.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
[css-ui] Add `outline-offset: inset`
https://bugs.webkit.org/show_bug.cgi?id=317779
rdar://180547604
Reviewed by Elika Etemad.
Expose the -internal-inset value to the web now that
https://github.com/w3c/csswg-drafts/issues/13765 has been resolved on.
`outline-offset: inset` resolves to the negation of the used outline-width. Its
computed value is always `inset` to avoid exposing the native outline's used
width.
Tests: fast/forms/select/base/option-focus-visible-outline-offset.html
fast/forms/select/base/option-inset-outline-offset.html
imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-001.html
imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-002.html
imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-003.html
imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-004.html
imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-005.html
imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-006.html
*
LayoutTests/fast/forms/select/base/option-focus-visible-outline-offset-expected.txt:
* LayoutTests/fast/forms/select/base/option-focus-visible-outline-offset.html:
* LayoutTests/fast/forms/select/base/option-inset-outline-offset-expected.txt:
Added.
* LayoutTests/fast/forms/select/base/option-inset-outline-offset.html: Renamed
from
LayoutTests/fast/forms/select/base/option-internal-inset-outline-offset.html.
*
LayoutTests/fast/forms/select/base/option-internal-inset-outline-offset-expected.txt:
Removed.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-001-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-001-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-001.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-002-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-002-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-002.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-003-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-003-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-003.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-004-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-004-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-004.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-005-expected.xht:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-005.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-006-expected-mismatch.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-006-notref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-offset-inset-006.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-invalid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-invalid.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-valid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-valid.html:
*
LayoutTests/platform/ios/fast/forms/select/base/option-focus-visible-outline-offset-expected.txt:
*
LayoutTests/platform/ios/fast/forms/select/base/option-inset-outline-offset-expected.txt:
Added.
*
LayoutTests/platform/ios/fast/forms/select/base/option-internal-inset-outline-offset-expected.txt:
Removed.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/html.css:
(select option:focus-visible):
* Source/WebCore/style/StyleExtractorCustom.h:
(WebCore::Style::ExtractorCustom::extractOutlineOffset):
(WebCore::Style::ExtractorCustom::extractOutlineOffsetSerialization):
* Source/WebCore/style/computed/StyleComputedStyle.cpp:
(WebCore::Style::ComputedStyle::usedOutlineOffset const):
* Source/WebCore/style/computed/StyleComputedStyle.h:
* Source/WebCore/style/values/outline/StyleOutlineOffset.h:
(WebCore::Style::OutlineOffset::isInset const):
(WebCore::Style::OutlineOffset::isInternalInset const): Deleted.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::usedOutlineOffset):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/316677@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
