Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dbe4d06e8673cdcdc71f6ba543cfbb41d8d75bd9
https://github.com/WebKit/WebKit/commit/dbe4d06e8673cdcdc71f6ba543cfbb41d8d75bd9
Author: Wenson Hsieh <[email protected]>
Date: 2026-07-08 (Wed, 08 Jul 2026)
Changed paths:
M Source/WebKit/SourcesCocoa.txt
A Source/WebKit/UIProcess/API/Cocoa/WKWebView+TextExtraction.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKTextExtractionInternal.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
Move text-extraction code out of WKWebView.mm into WKWebView+TextExtraction.mm
https://bugs.webkit.org/show_bug.cgi?id=318724
rdar://181530252
Reviewed by Abrar Rahman Protyasha and Richard Robinson.
Move text-extraction-related code out of `WKWebView.mm`, and into a separate
category (and
submodule), `WKWebView+TextExtraction.mm`.
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView+TextExtraction.mm: Added.
(-[WKWebView
_simulateClickOverFirstMatchingTextInViewportWithUserInteraction:completionHandler:]):
(-[WKWebView _takeSnapshotOfNode:completionHandler:]):
(-[WKWebView _getSelectorPathDataForNode:completionHandler:]):
(-[WKWebView _getSelectorPathData:completionHandler:]):
(-[WKWebView _getNodeForSelectorPathData:completionHandler:]):
(extractReplacementStrings):
(textExtractionOutputFormat):
(createEmptyTextExtractionResult):
(-[WKWebView _ensureTextExtractionFilterRulesWithCompletionHandler:]):
(-[WKWebView
_extractDebugTextWithConfigurationWithoutUpdatingFilterRules:assertionScope:completionHandler:]):
(-[WKWebView _convertToWebCoreInteraction:nodeIdentifier:]):
(nameForAction):
(-[WKWebView
_performInteraction:inFrame:actionType:nodeIdentifier:staleNodeNote:shouldResolveStaleNodeIdentifier:completionHandler:]):
(-[WKWebView
_filterExtractedStringWithoutUpdatingFilterRules:options:completionHandler:]):
(extractHandleIdentifiersOfNodesToSkip):
(extractClientNodeAttributes):
(coreEventListenerCategories):
(coreDataDetectorTypes):
(-[WKWebView _requestTextExtractionInternal:completion:]):
(-[WKWebView _requestTextExtraction:completionHandler:]):
(-[WKWebView _describeInteraction:completionHandler:]):
(-[WKWebView
_describeInteraction:inFrame:nodeIdentifier:staleNodeNote:shouldResolveStaleNodeIdentifier:completionHandler:]):
(-[WKWebView _textExtractionIdentifier]):
(-[WKWebView _validateText:inFrame:inNode:completionHandler:]):
(-[WKWebView _clearTextExtractionFilterCache]):
(-[WKWebView _requestJSHandleForNodeIdentifier:searchText:completionHandler:]):
(-[WKWebView
_requestContainerJSHandleForNodeIdentifier:searchText:completionHandler:]):
(-[WKWebView
_requestContainerJSHandleForSearchTexts:nodeIdentifier:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(WebKit::jsHandleIdentifierInFrame):
(-[WKWebView
willBeginWritingToolsSession:forProofreadingReview:requestContexts:]):
(-[WKWebView _refreshControlVisibleHeight]):
(jsHandleIdentifierInFrame): Deleted.
(-[WKWebView
_simulateClickOverFirstMatchingTextInViewportWithUserInteraction:completionHandler:]):
Deleted.
(-[WKWebView _takeSnapshotOfNode:completionHandler:]): Deleted.
(extractReplacementStrings): Deleted.
(textExtractionOutputFormat): Deleted.
(-[WKWebView _ensureTextExtractionFilterRulesWithCompletionHandler:]): Deleted.
(-[WKWebView
_extractDebugTextWithConfigurationWithoutUpdatingFilterRules:assertionScope:completionHandler:]):
Deleted.
(-[WKWebView _convertToWebCoreInteraction:nodeIdentifier:]): Deleted.
(-[WKWebView
_performInteraction:inFrame:actionType:nodeIdentifier:staleNodeNote:shouldResolveStaleNodeIdentifier:completionHandler:]):
Deleted.
(-[WKWebView _getSelectorPathDataForNode:completionHandler:]): Deleted.
(-[WKWebView _getSelectorPathData:completionHandler:]): Deleted.
(-[WKWebView _getNodeForSelectorPathData:completionHandler:]): Deleted.
(-[WKWebView
_filterExtractedStringWithoutUpdatingFilterRules:options:completionHandler:]):
Deleted.
(extractHandleIdentifiersOfNodesToSkip): Deleted.
(extractClientNodeAttributes): Deleted.
(coreEventListenerCategories): Deleted.
(coreDataDetectorTypes): Deleted.
(-[WKWebView _requestTextExtractionInternal:completion:]): Deleted.
(-[WKWebView _requestTextExtraction:completionHandler:]): Deleted.
(-[WKWebView _describeInteraction:completionHandler:]): Deleted.
(-[WKWebView
_describeInteraction:inFrame:nodeIdentifier:staleNodeNote:shouldResolveStaleNodeIdentifier:completionHandler:]):
Deleted.
(-[WKWebView _textExtractionIdentifier]): Deleted.
(-[WKWebView _validateText:inFrame:inNode:completionHandler:]): Deleted.
(-[WKWebView _clearTextExtractionFilterCache]): Deleted.
(-[WKWebView _requestJSHandleForNodeIdentifier:searchText:completionHandler:]):
Deleted.
(-[WKWebView
_requestContainerJSHandleForNodeIdentifier:searchText:completionHandler:]):
Deleted.
(-[WKWebView
_requestContainerJSHandleForSearchTexts:nodeIdentifier:completionHandler:]):
Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/316714@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
