Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5e696253517b823a40b739bd8aa4bd7a4fbbfc52
https://github.com/WebKit/WebKit/commit/5e696253517b823a40b739bd8aa4bd7a4fbbfc52
Author: Pascoe <[email protected]>
Date: 2026-07-08 (Wed, 08 Jul 2026)
Changed paths:
M Source/WebKit/PlatformMac.cmake
Log Message:
-----------
[CMake] Preprocess the sandbox profiles with the target SDK's -isysroot
https://bugs.webkit.org/show_bug.cgi?id=318720
rdar://181529363
Reviewed by Elliott Williams.
The .sb sandbox profiles are preprocessed with clang -E but without
-isysroot, so clang uses its default SDK. WebKit's C++ is compiled with the
target SDK, where USE(APPLE_INTERNAL_SDK) is decided by __has_include of
internal headers that only resolve under the Internal SDK's -isysroot; the
sandbox preprocess then takes the wrong branch and cannot resolve SDK headers
like <AppleFeatures/AppleFeatures.h>. Xcode's rule uses -isysroot $(SDKROOT).
Seed _sb_extra_includes with -isysroot ${CMAKE_OSX_SYSROOT} (and append,
rather than overwrite, the additions-SDK include so the seed survives).
* Source/WebKit/PlatformMac.cmake:
Canonical link: https://commits.webkit.org/316731@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
