Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 703147b98b786c615736c059bd305e2e80e8084b
https://github.com/WebKit/WebKit/commit/703147b98b786c615736c059bd305e2e80e8084b
Author: Pascoe <[email protected]>
Date: 2026-07-08 (Wed, 08 Jul 2026)
Changed paths:
M Tools/TestWebKitAPI/PlatformMac.cmake
Log Message:
-----------
[CMake] TestWebKitAPI is missing the mac GamepadMappings sources and the HID
framework link
https://bugs.webkit.org/show_bug.cgi?id=318698
rdar://181513616
Reviewed by Elliott Williams and Zak Ridouh.
Xcode's TestWebKitAPILibrary compiles the nine
Tools/TestWebKitAPI/Helpers/mac/GamepadMappings/*.mm files that define
TestWebKitAPI::VirtualGamepad::*Mapping(), referenced by
Helpers/mac/VirtualGamepad.mm and the HID gamepad tests, and links the
HID framework for HIDUserDevice (WK_HID_LDFLAGS_macosx = -framework HID).
The CMake port's PlatformMac.cmake lists VirtualGamepad.mm but omits the
mapping sources and the HID link, so TestWebKitAPI fails to link with
undefined VirtualGamepad mapping symbols and _OBJC_CLASS_$_HIDUserDevice.
Add the mapping sources and -framework HID to match Xcode.
* Tools/TestWebKitAPI/PlatformMac.cmake:
Canonical link: https://commits.webkit.org/316733@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
