Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4631a8c67fe674490b870a20facd2c56c3313b80
https://github.com/WebKit/WebKit/commit/4631a8c67fe674490b870a20facd2c56c3313b80
Author: Yulun Wu <[email protected]>
Date: 2026-07-08 (Wed, 08 Jul 2026)
Changed paths:
A
LayoutTests/scrollbars/custom-scrollbar-fractional-zoom-margin-crash-expected.txt
A LayoutTests/scrollbars/custom-scrollbar-fractional-zoom-margin-crash.html
M Source/WebCore/rendering/RenderScrollbarPart.h
Log Message:
-----------
Remove overrides from WebCore::RenderScrollbarPart::marginTop()
https://bugs.webkit.org/show_bug.cgi?id=274366
rdar://128355630
Reviewed by Simon Fraser.
RenderScrollbarPart overrode
marginTop()/marginBottom()/marginLeft()/marginRight()
to add an assert that required scrollbar-part margins to be whole integers.
This crashed the web process on google.com when signed in and zoomed.
After discussing with Simon, it was decided that fractional margins are not a
problem and we should instead simply remove the override.
* Source/WebCore/rendering/RenderScrollbarPart.h:
(WebCore::RenderScrollbarPart::marginTop): Deleted.
(WebCore::RenderScrollbarPart::marginBottom): Deleted.
(WebCore::RenderScrollbarPart::marginLeft): Deleted.
(WebCore::RenderScrollbarPart::marginRight): Deleted.
* LayoutTests/scrollbars/custom-scrollbar-fractional-zoom-margin-crash.html:
Added.
*
LayoutTests/scrollbars/custom-scrollbar-fractional-zoom-margin-crash-expected.txt:
Added.
Canonical link: https://commits.webkit.org/316741@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
