Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2181419aebfb55a717a2ddd8e3d2cb213a9c6e5
https://github.com/WebKit/WebKit/commit/f2181419aebfb55a717a2ddd8e3d2cb213a9c6e5
Author: Alan Baradlay <[email protected]>
Date: 2026-07-08 (Wed, 08 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[cleanup] Give FlexLayoutItem a flow-aware location and reference baseline
group members by index
https://bugs.webkit.org/show_bug.cgi?id=318443
Reviewed by Antti Koivisto.
FlexLayoutItem now carries its own flow-aware location, applied to the renderer
by the new setFlexItemGeometry().
The main placement site writes it and applies it -- the renderer still gets the
same setLocation call, so the field is written-only for now; it is groundwork
toward making the item, rather than the renderer, the source of truth for flex
geometry.
BaselineSharingGroup now records its members as indices into the owning line's
items (Vector<size_t>) instead of Vector<CheckedRef<RenderBox>>. The line's
items live in the stable allItems list, so an index is a safe.
No change in behavior.
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::setFlexItemGeometry):
(WebCore::RenderFlexibleBox::layoutAndPlaceFlexItems):
(WebCore::RenderFlexibleBox::performBaselineAlignment):
Canonical link: https://commits.webkit.org/316754@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications