Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8dbdbd31a3a708148947b21f68e2f72c2dd5e12e
https://github.com/WebKit/WebKit/commit/8dbdbd31a3a708148947b21f68e2f72c2dd5e12e
Author: Zak Ridouh <[email protected]>
Date: 2026-07-08 (Wed, 08 Jul 2026)
Changed paths:
M Tools/Scripts/webkit-build-directory
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/config.py
M Tools/Scripts/webkitpy/port/config_unittest.py
M Tools/Scripts/webkitpy/port/factory.py
Log Message:
-----------
[CMake] Add --asan support to run-webkit-tests for ASan builds
https://bugs.webkit.org/show_bug.cgi?id=318769
rdar://181625104
Reviewed by Pascoe.
Previously there was no way to point run-webkit-tests at the mac-asan
CMake preset build (WebKitBuild/cmake-mac/ASan): the build-directory
logic only understood Debug/Release, so `--cmake` could never resolve
the sanitizer tree.
Add a standalone `--asan` option (usable with `--cmake`, and independent
of --debug/--release) that resolves the build directory to
cmake-mac/ASan and reports the test configuration as ASan so the right
expectations apply. The webkitdirs sanitizer state now also honors an
`--asan`/`--tsan` argument, mirroring how `--cmake` is handled, in
addition to the existing set-webkit-configuration marker file.
Xcode marker-file users are unaffected: the ASan directory redirect is
scoped to the CMake branch, and marker detection is unchanged.
* Tools/Scripts/webkit-build-directory:
* Tools/Scripts/webkitdirs.pm:
(determineASanIsEnabled):
(determineTSanIsEnabled):
(determineConfigurationProductDir):
* Tools/Scripts/webkitpy/port/base.py:
(Port.__init__):
* Tools/Scripts/webkitpy/port/config.py:
(Config.__init__):
(Config.build_directory):
(Config.asan):
* Tools/Scripts/webkitpy/port/config_unittest.py:
(ConfigTest.make_config):
(ConfigTest.test_build_directory_passes_asan_flag):
(ConfigTest.test_build_directory_passes_asan_flag.mock_run_command):
(ConfigTest):
(ConfigTest.test_asan_marker_without_flag_is_unchanged):
(ConfigTest.test_asan_marker_without_flag_is_unchanged.mock_run_command):
(ConfigTest.test_asan):
* Tools/Scripts/webkitpy/port/factory.py:
(configuration_options):
Canonical link: https://commits.webkit.org/316761@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
