Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e0379cc1eaf93b9b3466541151867de7655d9e75
https://github.com/WebKit/WebKit/commit/e0379cc1eaf93b9b3466541151867de7655d9e75
Author: Alan Baradlay <[email protected]>
Date: 2026-07-08 (Wed, 08 Jul 2026)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/rendering/EllipsisBoxPainter.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextPainter.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlockInlines.h
M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp
M Source/WebCore/style/InlineTextBoxStyle.cpp
Log Message:
-----------
[cleanup] Remove the subpixelInlineLayoutEnabled setting and integer-snapping
helpers now that subpixel inline layout always enabled
https://bugs.webkit.org/show_bug.cgi?id=318871
<rdar://problem/181709802>
Reviewed by Antti Koivisto.
SubpixelInlineLayoutEnabled is enabled everywhere so the "snap inline metrics
to integers" path it gated is dead code. Remove the setting along with the
helper functions that existed only to pick between the subpixel value and the
integer-snapped one, and inline the subpixel (non-snapping) branch at every call
site.
No change in behavior.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Remove
SubpixelInlineLayoutEnabled.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
Remove snapToInt, ascent, descent and SnapDirection.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::logicalRectForTextRun):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::primaryFontMetricsForInlineBox):
(WebCore::Layout::layoutBoundstWithEdgeAdjustmentForInlineBox):
(WebCore::Layout::textBoxAdjustedInlineBoxHeight):
(WebCore::Layout::LineBoxBuilder::enclosingAscentDescentWithFallbackFonts):
(WebCore::Layout::LineBoxBuilder::setLayoutBoundsForInlineBox):
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox):
* Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp:
(WebCore::Layout::InlineQuirks::initialLetterAlignmentOffset):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
*
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
Remove local snapToInt/ascent helpers.
(WebCore::LayoutIntegration::fontMetricsBasedBaseline):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::baselineForEmptyContent):
* Source/WebCore/rendering/EllipsisBoxPainter.cpp:
* Source/WebCore/rendering/RenderBlock.cpp:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::lineHeightForEmptyContent):
(WebCore::RenderBlockFlow::firstLineBaseline):
(WebCore::RenderBlockFlow::lastLineBaseline):
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::lastLineBaseline):
* Source/WebCore/rendering/RenderGrid.cpp:
* Source/WebCore/rendering/RenderImage.cpp:
* Source/WebCore/rendering/RenderListMarker.cpp: Remove local snap() helper and
SnapDirection.
(WebCore::RenderListMarker::layoutBoundForTextContent):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::firstLineBaseline):
(WebCore::RenderTable::lastLineBaseline):
* Source/WebCore/rendering/TextBoxPainter.cpp: Remove local snap() helper.
* Source/WebCore/rendering/TextPainter.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::firstLineBaseline):
* Source/WebCore/rendering/mathml/RenderMathMLBlockInlines.h:
(WebCore::RenderMathMLBlock::ascentForChild):
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::firstLineBaseline):
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::firstLineBaseline):
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::firstLineBaseline):
* Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::firstLineBaseline):
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
* Source/WebCore/style/InlineTextBoxStyle.cpp: Remove local snap() helper.
Canonical link: https://commits.webkit.org/316763@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
