Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2fa9993ac40a62d9529a164d6a5559b5f7d0d8a5
https://github.com/WebKit/WebKit/commit/2fa9993ac40a62d9529a164d6a5559b5f7d0d8a5
Author: Brent Fulgham <[email protected]>
Date: 2026-07-09 (Thu, 09 Jul 2026)
Changed paths:
M LayoutTests/fast/forms/box-shadow-override.html
M LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html
M LayoutTests/fast/forms/disabled-search-input.html
M
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance-expected-mismatch.html
M
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance.html
M LayoutTests/fast/forms/placeholder-position.html
M LayoutTests/fast/forms/search-abs-pos-cancel-button.html
M
LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings-expected.html
M LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings.html
M LayoutTests/fast/forms/search-input-rtl.html
M LayoutTests/fast/forms/search-rtl.html
M LayoutTests/fast/forms/search-styled.html
M LayoutTests/fast/forms/search-transformed.html
M LayoutTests/fast/forms/search-zoomed.html
M LayoutTests/fast/forms/search/search-padding-cancel-results-buttons.html
M LayoutTests/fast/forms/search/search-recent-searches.html
A
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default-expected.txt
A
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default.html
M LayoutTests/fast/forms/search/search-results-hidden-crash.html
M LayoutTests/fast/forms/search/search-size-with-decorations.html
M LayoutTests/fast/replaced/width100percent-searchfield.html
M LayoutTests/imported/blink/fast/forms/search-popup-crasher.html
M LayoutTests/pdf/crash-with-embed-hidden.html
M
LayoutTests/platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt
M LayoutTests/platform/gtk/fast/css/input-search-padding-expected.txt
M
LayoutTests/platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/gtk/fast/forms/control-restrict-line-height-expected.txt
M LayoutTests/platform/gtk/fast/forms/input-appearance-height-expected.txt
M LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt
M LayoutTests/platform/gtk/fast/forms/search-vertical-alignment-expected.txt
M LayoutTests/platform/gtk/fast/forms/searchfield-heights-expected.txt
M
LayoutTests/platform/ios/fast/css/focus-ring-exists-for-search-field-expected.txt
M LayoutTests/platform/ios/fast/css/input-search-padding-expected.txt
M
LayoutTests/platform/ios/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt
M
LayoutTests/platform/ios/fast/forms/datalist/datalist-searchinput-appearance-expected.txt
M LayoutTests/platform/ios/fast/forms/input-appearance-height-expected.txt
M LayoutTests/platform/ios/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/ios/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/ios/fast/forms/search-display-none-cancel-button-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/control-restrict-line-height-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/input-appearance-height-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-display-none-cancel-button-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-vertical-alignment-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/repaint/search-field-cancel-expected.txt
M
LayoutTests/platform/mac-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt
M
LayoutTests/platform/mac-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/mac-wk2/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/input-appearance-height-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/search-display-none-cancel-button-expected.txt
M
LayoutTests/platform/mac-wk2/fast/forms/search-vertical-alignment-expected.txt
M LayoutTests/platform/mac-wk2/fast/repaint/search-field-cancel-expected.txt
M
LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt
M
LayoutTests/platform/wpe/fast/css/focus-ring-exists-for-search-field-expected.txt
M LayoutTests/platform/wpe/fast/css/input-search-padding-expected.txt
M
LayoutTests/platform/wpe/fast/css/text-input-with-webkit-border-radius-expected.txt
M LayoutTests/platform/wpe/fast/css/text-overflow-input-expected.txt
M
LayoutTests/platform/wpe/fast/forms/control-restrict-line-height-expected.txt
M LayoutTests/platform/wpe/fast/forms/input-appearance-height-expected.txt
M LayoutTests/platform/wpe/fast/forms/placeholder-pseudo-style-expected.txt
M
LayoutTests/platform/wpe/fast/forms/search-cancel-button-style-sharing-expected.txt
M
LayoutTests/platform/wpe/fast/forms/search-display-none-cancel-button-expected.txt
M LayoutTests/platform/wpe/fast/forms/search-vertical-alignment-expected.txt
M LayoutTests/platform/wpe/fast/forms/searchfield-heights-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/SearchInputType.cpp
M Source/WebCore/rendering/RenderSearchField.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.h
M Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm
M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h
M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm
Log Message:
-----------
roland.com: Double search icon in search field (works in Chrome)
https://bugs.webkit.org/show_bug.cgi?id=317437
<rdar://problem/179949639>
Reviewed by Tim Nguyen.
Reland 316422@main after resolving the debug assertion that forced us to revert.
The Roland support site (static.roland.com) shows two magnifying glass icons in
Safari's
search field where Chrome shows only one.
The HTML is:
<input class="form-control" type="search" name="q" results="10" ...>
with CSS `appearance: none` and a `background-image: url(search.svg)` that
paints the
site's own magnifying glass. The legacy WebKit-only `results=N` attribute opts
the input
into ::-webkit-search-results-button, which caused WebKit to paint a search
icon.
The fix is to match Chrome and Firefox behavior by removing the `results=N`
feature
when WebKit is used for web browsing. We retain it for backwards compatibility
with
apps that may depend on it.
We gate the deprecation on a Linked-On-Or-After check so we avoid changing
behavior
unexpectedly. Developers can re-enable the feature using the new feature flag.
I have also rebaselined the tests that were not specifically testing this
deprecated
feature, but had layout impact now that the deprecated decoration is no longer
automatically
added to search fields.
Test: fast/forms/search/search-results-attribute-disabled-by-default.html
* LayoutTests/fast/forms/box-shadow-override.html:
* LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html:
* LayoutTests/fast/forms/disabled-search-input.html:
*
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance-expected-mismatch.html:
*
LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance.html:
* LayoutTests/fast/forms/placeholder-position.html:
* LayoutTests/fast/forms/search-abs-pos-cancel-button.html:
*
LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings-expected.html:
* LayoutTests/fast/forms/search-field-buttons-do-not-have-focus-rings.html:
* LayoutTests/fast/forms/search-input-rtl.html:
* LayoutTests/fast/forms/search-rtl.html:
* LayoutTests/fast/forms/search-styled.html:
* LayoutTests/fast/forms/search-transformed.html:
* LayoutTests/fast/forms/search-zoomed.html:
* LayoutTests/fast/forms/search/search-padding-cancel-results-buttons.html:
* LayoutTests/fast/forms/search/search-recent-searches.html:
*
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default-expected.txt:
Added.
*
LayoutTests/fast/forms/search/search-results-attribute-disabled-by-default.html:
Added.
* LayoutTests/fast/forms/search/search-results-hidden-crash.html:
* LayoutTests/fast/forms/search/search-size-with-decorations.html:
* LayoutTests/fast/replaced/width100percent-searchfield.html:
* LayoutTests/imported/blink/fast/forms/search-popup-crasher.html:
* LayoutTests/pdf/crash-with-embed-hidden.html:
*
LayoutTests/platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
* LayoutTests/platform/gtk/fast/css/input-search-padding-expected.txt:
*
LayoutTests/platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.txt:
* LayoutTests/platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/gtk/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* LayoutTests/platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
* LayoutTests/platform/gtk/fast/forms/searchfield-heights-expected.txt:
*
LayoutTests/platform/ios/fast/css/focus-ring-exists-for-search-field-expected.txt:
* LayoutTests/platform/ios/fast/css/input-search-padding-expected.txt:
*
LayoutTests/platform/ios/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/ios/fast/css/text-overflow-input-expected.txt:
* LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt:
*
LayoutTests/platform/ios/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
* LayoutTests/platform/ios/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/ios/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/ios/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/ios/fast/forms/search-display-none-cancel-button-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/css/text-overflow-input-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/control-restrict-line-height-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/input-appearance-height-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-display-none-cancel-button-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/forms/search-vertical-alignment-expected.txt:
*
LayoutTests/platform/mac-sequoia-wk2/fast/repaint/search-field-cancel-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/css/focus-ring-exists-for-search-field-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/mac-wk2/fast/css/text-overflow-input-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
* LayoutTests/platform/mac-wk2/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/mac-wk2/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/search-display-none-cancel-button-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/forms/search-vertical-alignment-expected.txt:
* LayoutTests/platform/mac-wk2/fast/repaint/search-field-cancel-expected.txt:
* LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt:
*
LayoutTests/platform/wpe/fast/css/focus-ring-exists-for-search-field-expected.txt:
* LayoutTests/platform/wpe/fast/css/input-search-padding-expected.txt:
*
LayoutTests/platform/wpe/fast/css/text-input-with-webkit-border-radius-expected.txt:
* LayoutTests/platform/wpe/fast/css/text-overflow-input-expected.txt:
* LayoutTests/platform/wpe/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/wpe/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/wpe/fast/forms/placeholder-pseudo-style-expected.txt:
*
LayoutTests/platform/wpe/fast/forms/search-cancel-button-style-sharing-expected.txt:
*
LayoutTests/platform/wpe/fast/forms/search-display-none-cancel-button-expected.txt:
* LayoutTests/platform/wpe/fast/forms/search-vertical-alignment-expected.txt:
* LayoutTests/platform/wpe/fast/forms/searchfield-heights-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attributeChanged):
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::showPopup):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultSearchInputResultsAttributeEnabled):
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
* Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:
(WebKit::WebPreferences::platformInitializeStore):
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h:
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultSearchInputResultsAttributeEnabled):
Canonical link: https://commits.webkit.org/316837@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
