Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a672bedbf6c7200860080238f76bdd2c48e2e87
https://github.com/WebKit/WebKit/commit/6a672bedbf6c7200860080238f76bdd2c48e2e87
Author: Taher Ali <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M Source/WebCore/svg/SVGTextPositioningElement.cpp
M Source/WebCore/svg/SVGTextPositioningElement.h
Log Message:
-----------
Remove redundant x/y presentation-hint overrides from
SVGTextPositioningElement
https://bugs.webkit.org/show_bug.cgi?id=318983
rdar://181838675
Reviewed by Nikolas Zimmermann.
SVGTextPositioningElement (the base for <text>, <tspan>, <tref>, <altGlyph>)
overrode
hasPresentationalHintsForAttribute/collectPresentationalHintsForAttribute
to opt x/y out of presentation-hint mapping. That restates a decision the
central SVGElement::cssPropertyIdForSVGAttributeName mapping already makes: its
supportsXY() set is {foreignObject, image, rect, svg, symbol, use}, which
excludes
all text-positioning elements, so the base already returns false / emits nothing
for x/y on these elements.
No behavior change.
* Source/WebCore/svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::collectPresentationalHintsForAttribute):
Deleted.
(WebCore::SVGTextPositioningElement::hasPresentationalHintsForAttribute const):
Deleted.
* Source/WebCore/svg/SVGTextPositioningElement.h:
Canonical link: https://commits.webkit.org/316906@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
