Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 13d509ea8a1a250ac12266f8ba6ccfd2b1c5bf0e
https://github.com/WebKit/WebKit/commit/13d509ea8a1a250ac12266f8ba6ccfd2b1c5bf0e
Author: Andy Estes <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
A LayoutTests/media/wireless-playback-media-player/muted-expected.txt
A LayoutTests/media/wireless-playback-media-player/muted.html
A
LayoutTests/media/wireless-playback-media-player/route-muted-change-expected.txt
A LayoutTests/media/wireless-playback-media-player/route-muted-change.html
A
LayoutTests/media/wireless-playback-media-player/route-pauses-playback-expected.txt
A
LayoutTests/media/wireless-playback-media-player/route-pauses-playback.html
A
LayoutTests/media/wireless-playback-media-player/route-playback-rate-change-expected.txt
A
LayoutTests/media/wireless-playback-media-player/route-playback-rate-change.html
A
LayoutTests/media/wireless-playback-media-player/route-stops-advancing-current-time-expected.txt
A
LayoutTests/media/wireless-playback-media-player/route-stops-advancing-current-time.html
A
LayoutTests/media/wireless-playback-media-player/route-volume-change-expected.txt
A
LayoutTests/media/wireless-playback-media-player/route-volume-change-locked-expected.txt
A
LayoutTests/media/wireless-playback-media-player/route-volume-change-locked.html
A LayoutTests/media/wireless-playback-media-player/route-volume-change.html
M Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp
M Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.h
M Source/WebCore/testing/MockMediaDeviceRoute.h
M Source/WebCore/testing/MockMediaDeviceRoute.idl
M Source/WebCore/testing/MockMediaDeviceRoute.mm
Log Message:
-----------
[iOS] Playing, rate, and volume changes originating from a MediaDeviceRoute
are not reflected in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=319028
rdar://181881466
Reviewed by Youenn Fablet.
MediaPlayerPrivateWirelessPlayback did not implement playbackPositionDidChange,
playingDidChange,
playbackSpeedDidChange, or volumeDidChange from MediaDeviceRouteClient. As a
result, changes to
these properties made by the MediaDeviceRoute were not propagated to
HTMLMediaElement.
Additionally, MediaPlayerPrivateWirelessPlayback did not properly implement
setMuted, preventing
the webage from muting playback occurring on a MediaDeviceRoute.
Addressed these problems by implementing the above functions. While here, made
the logging in
playbackPositionDidChange less noisy by only logging during a seek.
Covered by new layout tests.
Tests: media/wireless-playback-media-player/muted.html
media/wireless-playback-media-player/route-muted-change.html
media/wireless-playback-media-player/route-pauses-playback.html
media/wireless-playback-media-player/route-playback-rate-change.html
media/wireless-playback-media-player/route-stops-advancing-current-time.html
media/wireless-playback-media-player/route-volume-change.html
* LayoutTests/media/wireless-playback-media-player/muted-expected.txt: Added.
* LayoutTests/media/wireless-playback-media-player/muted.html: Added.
*
LayoutTests/media/wireless-playback-media-player/route-muted-change-expected.txt:
Added.
* LayoutTests/media/wireless-playback-media-player/route-muted-change.html:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-pauses-playback-expected.txt:
Added.
* LayoutTests/media/wireless-playback-media-player/route-pauses-playback.html:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-playback-rate-change-expected.txt:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-playback-rate-change.html:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-stops-advancing-current-time-expected.txt:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-stops-advancing-current-time.html:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-volume-change-expected.txt:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-volume-change-locked-expected.txt:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-volume-change-locked.html:
Added.
* LayoutTests/media/wireless-playback-media-player/route-volume-change.html:
Added.
* Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp:
(WebCore::MediaPlayerPrivateWirelessPlayback::effectiveRate const):
(WebCore::MediaPlayerPrivateWirelessPlayback::setMuted):
(WebCore::MediaPlayerPrivateWirelessPlayback::playbackPositionDidChange):
(WebCore::MediaPlayerPrivateWirelessPlayback::playingDidChange):
(WebCore::MediaPlayerPrivateWirelessPlayback::playbackSpeedDidChange):
(WebCore::MediaPlayerPrivateWirelessPlayback::mutedDidChange):
(WebCore::MediaPlayerPrivateWirelessPlayback::volumeDidChange):
* Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.h:
* Source/WebCore/testing/MockMediaDeviceRoute.h:
* Source/WebCore/testing/MockMediaDeviceRoute.idl:
* Source/WebCore/testing/MockMediaDeviceRoute.mm:
(WebCore::MockMediaDeviceRoute::muted const):
(WebCore::MockMediaDeviceRoute::setMuted):
Canonical link: https://commits.webkit.org/316924@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
