Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 84403b849ed180a7ef72cbb40a06a9dbbf7036bc
https://github.com/WebKit/WebKit/commit/84403b849ed180a7ef72cbb40a06a9dbbf7036bc
Author: Sammy Gill <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/GridTypeAliases.h
M Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.cpp
M Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.h
Log Message:
-----------
[GFC][Cleanup] ResolveIntrinsicTrackSizesContext has redundant fields.
https://bugs.webkit.org/show_bug.cgi?id=319021
rdar://181867411
Reviewed by Alan Baradlay and Brandon Stewart.
ResolveIntrinsicTrackSizesContext is a struct that is used during the
"resolve intrinsic track sizes," portion of the spec. This struct
contains a list of TrackSizingItems and some fields that contain other
pieces of data. Some of these other pieces of data are actually
redundant since they already live on TrackSizingItem so we do not
actually need them on this struct. We can remove these from the struct
and also pass the list of TrackSizingItems or the item itself into the
functions that were using the other fields from the struct.
Removing these fields leaves the ComputedSizesList and
UsedBorderAndPaddingList type aliases unused, so delete them as well.
While here, mark TrackSizingItem's members const since it is not
expected that any of these fields should ever get mutated.
* Source/WebCore/layout/formattingContexts/grid/GridTypeAliases.h:
Remove the now-unused ComputedSizesList and UsedBorderAndPaddingList
aliases.
* Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.cpp:
(WebCore::Layout::singleSpanningItemsWithinTrack):
Pass in the track sizing item instead and get the lines each item spans
off of it directly.
(WebCore::Layout::minimumContributions):
We already have the TrackSizingItem so use the fields off of it and
remove the rest as arguments.
Canonical link: https://commits.webkit.org/316939@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
