Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 60c9df371dd2c01a7fbce516d8d1954334d9437b
https://github.com/WebKit/WebKit/commit/60c9df371dd2c01a7fbce516d8d1954334d9437b
Author: Alan Baradlay <[email protected]>
Date: 2026-07-12 (Sun, 12 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[cleanup] Remove repositionLogicalHeightDependentFlexItems, calling the
cross-axis alignment phases directly
https://bugs.webkit.org/show_bug.cgi?id=318552
Reviewed by Antti Koivisto.
repositionLogicalHeightDependentFlexItems was a wrapper named for when it runs
(after the logical height is known) rather than what it does; FlexLayout::layout
has no such function -- its performContentAlignment calls the cross-axis
alignment
phases directly under the "Cross-Axis Alignment" comment. Legacy put that same
comment above the wrapper. Inline the wrapper so performContentAlignment calls
handleCrossAxisAlignmentForFlexLines, computeCrossSizeForFlexItems,
handleCrossAxisAlignmentForFlexItems, and the flips directly.
Pure code motion: the body runs at the same point the call did, and the lambda
captures the same lists the function took as arguments.
No change in behavior.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::performFlexLayout):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:
Canonical link: https://commits.webkit.org/316993@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
