Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9841b6f9f3840e5dc86f5d1097b73b929953be7b
https://github.com/WebKit/WebKit/commit/9841b6f9f3840e5dc86f5d1097b73b929953be7b
Author: Vitaly Dyachkov <[email protected]>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M LayoutTests/ipc/loadping-firstpartyforcookies-message-check.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
Log Message:
-----------
`ipc/loadping-firstpartyforcookies-message-check.html` is constant failure
with assertions enabled
https://bugs.webkit.org/show_bug.cgi?id=318436
Reviewed by Charlie Wolfe and Rupin Mittal.
Add missing `mayBlockNetworkRequest`, `globalPrivacyControlStatus`,
`shouldConsiderEnhancedSecurityForInsecureResponse`, and
`shouldBlockThirdPartyStorage` to `resourceLoadParameters` object.
With all these properties present, the test was crashing in debug builds
in `NetworkProcess::allowsFirstPartyForCookies()` at
`ASSERT(result || terminateOrDisallow == AllowCookieAccess::Disallow);`
It seems like this assertion is triggered on the exact case this test is
testing and can be dropped.
* LayoutTests/ipc/loadping-firstpartyforcookies-message-check.html:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::allowsFirstPartyForCookies):
Canonical link: https://commits.webkit.org/317024@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
