Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bdc93974d59a8126af66a76abd48bb6264dbcaf9
https://github.com/WebKit/WebKit/commit/bdc93974d59a8126af66a76abd48bb6264dbcaf9
Author: Jer Noble <[email protected]>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M LayoutTests/fullscreen/full-screen-test.js
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-change-event-shape-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-change-event-shape.html
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-exit-errors-and-async-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-exit-errors-and-async.html
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-hides-popovers-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-hides-popovers.html
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-idl-getters-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-idl-getters.html
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-request-preconditions-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-request-preconditions.html
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/fullscreen-exit-edges-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/fullscreen-exit-edges.html
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-ua-stylesheet-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-ua-stylesheet.html
Log Message:
-----------
[Fullscreen] Add tests for untested areas of the Fullscreen API specification
rdar://181518068
https://bugs.webkit.org/show_bug.cgi?id=318704
Reviewed by Andy Estes.
Add tests covering previously untested areas of the Fullscreen API
specification, driven by an audit against the spec's testable-behavior
extraction. No new WebKit bugs surfaced this batch — WebKit's Fullscreen
implementation is spec-conformant across everything tested.
fullscreen-change-event-shape.html verifies fullscreenchange event
properties: bubbles=true and composed=true (both spec-required per
"run the fullscreen steps"); target is the element when connected and
in-document, falling back to the document when the fullscreen element
was disconnected before exit-fullscreen ran; and that a single
request/exit cycle produces exactly one fullscreenchange event per
transition (the pending events list is drained per invocation).
fullscreen-idl-getters.html verifies Document.fullscreen (the deprecated
boolean getter) and Document.fullscreenElement (the current element or
null) across enter and exit transitions; also asserts the simple-
fullscreen-document invariant that the top layer contains exactly one
fullscreen element while entered.
fullscreen-ua-stylesheet.html verifies the UA default stylesheet rules
applied to :not(:root):fullscreen elements via getComputedStyle:
margin:0!important, box-sizing:border-box!important, and non-important
object-fit:contain (the non-important object-fit rule is properly
overridable by author !important rules).
fullscreen-exit-errors-and-async.html verifies that requestFullscreen
and exitFullscreen both return a Promise synchronously (their state
transitions happen in parallel), and that exitFullscreen rejects with
a TypeError when the document is not fully active (tested via a
detached iframe's contentDocument).
fullscreen-request-preconditions.html verifies the fullscreen-element-
ready-check preconditions: an element in an iframe whose allow
attribute denies fullscreen cannot enter fullscreen; and an HTML element
whose popover visibility state is "showing" cannot enter fullscreen
(the ready-check's "namespace is not HTML OR popover visibility state
is hidden" clause fails for showing HTML popovers), while a hidden
popover (element with popover attribute but not shown) IS eligible.
fullscreen-exit-edges.html verifies that when the fullscreen element is
disconnected from its document, the exit-fullscreen algorithm still
unfullscreens it — fullscreenElement returns to null after the
disconnection-triggered fullscreenchange fires.
fullscreen-hides-popovers.html verifies steps 1-2 of the fullscreen-an-
element algorithm (compute hideUntil via topmost-popover-ancestor; run
hide-popovers-until): when a non-popover element is fullscreened, all
currently-open auto popovers are hidden. Manual popovers stay open
because the hide-popovers-until algorithm only iterates the auto and
hint popover stacks.
* LayoutTests/fullscreen/full-screen-test.js:
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-change-event-shape-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-change-event-shape.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-exit-errors-and-async-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-exit-errors-and-async.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-hides-popovers-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-hides-popovers.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-idl-getters-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-idl-getters.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-request-preconditions-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-request-preconditions.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/fullscreen-exit-edges-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/fullscreen-exit-edges.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-ua-stylesheet-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-ua-stylesheet.html:
Added.
Canonical link: https://commits.webkit.org/317070@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
