Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e3ed02f433684992f8a9a77b473cd4794d4a1f4b
https://github.com/WebKit/WebKit/commit/e3ed02f433684992f8a9a77b473cd4794d4a1f4b
Author: Alan Baradlay <[email protected]>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[cleanup] Fold computeNextFlexLine into computeFlexLines and compute the
main-axis gap there
https://bugs.webkit.org/show_bug.cgi?id=318595
Reviewed by Antti Koivisto.
computeFlexLines drove a per-line helper, computeNextFlexLine, that returned a
FlexingLineData bundle. Only the per-line hypothetical main size was ever read
back;
the flex-factor sums it also computed (totalFlexGrow, totalFlexShrink,
totalWeightedFlexShrink) were dead -- resolveFlexibleLengthsForLineItems
recomputes
them. Inline the helper into the computeFlexLines loop, matching
FlexLayout::computeFlexLines, and compute the main-axis gap there instead of
passing
it in. Drop the now-unused FlexingLineData struct and the always-true
item-count guard
(the first uncollected item is always collected).
No change in behavior: the main-axis margin trim and the per-line hypothetical
main
size that columnInnerMainSize needs are preserved.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeFlexLines):
* Source/WebCore/rendering/RenderFlexibleBox.h:
Canonical link: https://commits.webkit.org/317078@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
