Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca723826fa2362a6818977464d264e1092d27e6f
https://github.com/WebKit/WebKit/commit/ca723826fa2362a6818977464d264e1092d27e6f
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M Source/WebInspectorUI/UserInterface/Views/DataGrid.js
Log Message:
-----------
Web Inspector: column resizer drag offset uses `this` for a static constant,
producing `left: NaNpx
https://bugs.webkit.org/show_bug.cgi?id=319342
rdar://182154868
Reviewed by Devin Rousso.
`WI.DataGrid.CenterResizerOverBorderAdjustment` is a static property on the
class constructor (assigned at the bottom of the file), so reading it off an
instance via `this.CenterResizerOverBorderAdjustment` in `resizerDragging()`
evaluates to `undefined`. `dragPoint - undefined` is `NaN`, so the call
becomes `setProperty("left", "NaNpx")`, which is invalid and silently ignored.
This regressed when DataGrid was converted from a prototype object (where the
constant lived on the prototype and `this.` resolved it correctly) to an ES6
class with the constant hoisted to a static. The sibling constants on the same
lines already use the fully-qualified `WI.DataGrid.ColumnResizePadding` form;
this reference was missed.
Qualify the reference with `WI.DataGrid.` to match its siblings.
* Source/WebInspectorUI/UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype.resizerDragging):
Canonical link: https://commits.webkit.org/317125@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
