Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5fc32e9843cb1070e514c2d27ce40142269c169d
https://github.com/WebKit/WebKit/commit/5fc32e9843cb1070e514c2d27ce40142269c169d
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-14 (Tue, 14 Jul 2026)
Changed paths:
M Source/WebCore/Modules/notifications/NotificationData.h
Log Message:
-----------
NotificationData::direction is serialized uninitialized when a
NotificationPayload has no options
https://bugs.webkit.org/show_bug.cgi?id=319238
rdar://182085034
Reviewed by Chris Dumez.
NotificationData::direction had no default member initializer, so when
NotificationPayload::toNotificationData() runs with no options, it stays
indeterminate and is then serialized over IPC (undefined behavior, and
possibly an out-of-range NotificationDirection).
Initialize it explicitly to NotificationDirection::Auto, and drop the
redundant WebCore:: qualifier since the struct is already in the WebCore
namespace.
Since the initializer now references the NotificationDirection::Auto
enumerator, the enum can no longer be an incomplete forward declaration.
Include <WebCore/NotificationDirection.h> and remove the forward
declaration so the enumerator is visible.
* Source/WebCore/Modules/notifications/NotificationData.h:
Canonical link: https://commits.webkit.org/317160@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
