Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: feecb29345df6e4857553174e997c4b90054c8da
https://github.com/WebKit/WebKit/commit/feecb29345df6e4857553174e997c4b90054c8da
Author: Alan Baradlay <[email protected]>
Date: 2026-07-14 (Tue, 14 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[cleanup] Snapshot the flex item cross-axis border+padding on FlexLayoutItem
https://bugs.webkit.org/show_bug.cgi?id=318600
Reviewed by Antti Koivsito.
Snapshot the flex item's cross-axis border+padding onto FlexLayoutItem,
mirroring the
existing mainAxisBorderAndPadding field. It is populated at construction from
the
flow-aware border+padding extent.
The only flow-based cross-axis border+padding read is in
computeMainSizeFromAspectRatioUsing,
so that helper and its caller
adjustFlexItemSizeForAspectRatioCrossAxisMinAndMax now take a
const FlexLayoutItem& (both are only ever reached from the item-having
flex-base subgraph) and
the read comes from the field. The read already ran during flex-base sizing, so
the
construction-time snapshot is the same value. The item-logical border+padding
reads in the
stretch path are left as-is: those are the item's own logical-height
border+padding, which
differs from the flow-based cross-axis value for orthogonal flows.
No change in behavior.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
* Source/WebCore/rendering/RenderFlexibleBox.h:
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Canonical link: https://commits.webkit.org/317183@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
