Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ebad5b591a41ffa838ca3b6a63aea19e8587799
https://github.com/WebKit/WebKit/commit/1ebad5b591a41ffa838ca3b6a63aea19e8587799
Author: Dan Hecht <[email protected]>
Date: 2026-07-14 (Tue, 14 Jul 2026)
Changed paths:
M Source/bmalloc/libpas/src/test/LargeFreeHeapTests.cpp
Log Message:
-----------
[libpas] Test zero_mode edge cases in LargeFreeHeapTests
https://bugs.webkit.org/show_bug.cgi?id=319401
rdar://182229562
Reviewed by Marcus Plutowski and Yusuke Suzuki.
Extend the zero_mode coverage to branches that were only ever exercised with
a single zero_mode (so they would pass even if the field were mishandled),
on both the simple and fast heaps:
- a fresh source chunk coalescing (find_by_end -> pas_large_free_create_merged)
with an adjacent existing free of a differing mode, feeding the result and
the leftover;
- best-fit selecting among candidate frees of differing modes (the winner's
mode flows to the result and its leftover; the unchosen free is untouched);
- a free coalescing with two neighbors at once (all eight three-way mode
combinations, across both heaps' differing fold orders);
- a zero-size allocation returning is_all_zero.
Tests: Source/bmalloc/libpas/src/test/LargeFreeHeapTests.cpp:
* Source/bmalloc/libpas/src/test/LargeFreeHeapTests.cpp:
(std::testFreshChunkCoalesceZeroMode):
(std::testBestFitCandidateZeroMode):
(std::testThreeWayCoalesceZeroMode):
(std::testZeroSizeAllocationIsAllZero):
(addLargeFreeHeapTests):
Canonical link: https://commits.webkit.org/317188@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications