Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b709f9a52609ca525c10eaeda0cc0ff9c8c9f52b
https://github.com/WebKit/WebKit/commit/b709f9a52609ca525c10eaeda0cc0ff9c8c9f52b
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-14 (Tue, 14 Jul 2026)
Changed paths:
A LayoutTests/inspector/timeline/import-errors-expected.txt
A LayoutTests/inspector/timeline/import-errors.html
M Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
Log Message:
-----------
Web Inspector: Timeline recording import reports "unsupported version" as a
HAR Import Error
https://bugs.webkit.org/show_bug.cgi?id=319403
rdar://182231038
Reviewed by Devin Rousso.
TimelineManager.processJSON() reports every import failure through
WI.TimelineManager.synthesizeImportError(), which prefixes the message
with "Timeline Recording Import Error:". The unsupported-version path
mistakenly called WI.NetworkManager.synthesizeImportError() instead,
which prefixes with "HAR Import Error:". As a result, importing a
timeline recording with an unsupported serialization version surfaced a
misleading "HAR Import Error: unsupported version" message.
Route the version-mismatch error through WI.TimelineManager like the
other error paths in processJSON().
* Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype.async processJSON):
* LayoutTests/inspector/timeline/import-errors-expected.txt: Added.
* LayoutTests/inspector/timeline/import-errors.html: Added.
Canonical link: https://commits.webkit.org/317217@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications