Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 458f187c01a96486f45a2eed1cf1fe1e96dd14a4
https://github.com/WebKit/WebKit/commit/458f187c01a96486f45a2eed1cf1fe1e96dd14a4
Author: Chris Dumez <[email protected]>
Date: 2026-07-14 (Tue, 14 Jul 2026)
Changed paths:
M Source/WTF/wtf/threads/Signals.cpp
Log Message:
-----------
Fix incorrect template argument in Signals.cpp CPU(ARM) exception handling
path
https://bugs.webkit.org/show_bug.cgi?id=319350
Reviewed by Darin Adler.
In catch_mach_exception_raise_state(), the CPU(ARM) (32-bit ARM) branch
passed a pointer type (arm_unified_thread_state*) as the template argument
to reinterpretCastSpanStartTo<>() instead of the value type, unlike every
sibling branch (X86_64, X86, ARM64). Since reinterpretCastSpanStartTo<T>()
returns T&, this produced a reference to a pointer, and applying .ts_32
(which expands to .uts.ts_32) to a pointer is ill-formed; it would also
have used sizeof(pointer) rather than the size of the thread-state struct.
This branch is only compiled for 32-bit ARM with Mach exceptions, which is
not a shipping WebKit configuration, so it was never caught by the build.
The typo was introduced during the span-based refactor of this function.
Correct it to use the value type, matching the ARM64 branch.
* Source/WTF/wtf/threads/Signals.cpp:
Canonical link: https://commits.webkit.org/317219@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
