Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4633fbc5a77475f264df74ea208e0018c321c1d1
https://github.com/WebKit/WebKit/commit/4633fbc5a77475f264df74ea208e0018c321c1d1
Author: Youenn Fablet <[email protected]>
Date: 2026-07-15 (Wed, 15 Jul 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webrtc-stats/getStats-remote-candidate-address-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/webrtc/candidate-stats.html
M LayoutTests/webrtc/datachannel/getStats-no-prflx-remote-candidate.html
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp
Log Message:
-----------
ICECandidate stats address member should be null when obfuscated
rdar://181801756
https://bugs.webkit.org/show_bug.cgi?id=318950
Reviewed by Jean-Yves Avenard.
To align with the spec, instead of using undefined we use null when we
obfuscate IceCandidate address member.
We rebase some WPT tests and update some layout tests accordingly.
We rebase in particular
LayoutTests/imported/w3c/web-platform-tests/webrtc-stats/getStats-remote-candidate-address-expected.txt,
one test changes to PASS and one to FAIL.
The first one changes to PASS as the test expects null and WebKit was
previously exposing undefined.
The second ones changes to FAIL as the test expects a value not null and WebKit
was exposing undefined (and now null).
A follow-up PR should allow exposing remote candidates whose address has been
given by the web page, whether an IP or a mDNS address.
*
LayoutTests/imported/w3c/web-platform-tests/webrtc-stats/getStats-remote-candidate-address-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/webrtc/candidate-stats.html:
* LayoutTests/webrtc/datachannel/getStats-no-prflx-remote-candidate.html:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::RTCStatsReport::IceCandidateStats::convert):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
(WebCore::RTCStatsReport::IceCandidateStats::convert):
Canonical link: https://commits.webkit.org/317238@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
