Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 081c4c12c5c5e20776b38bcd53856dfa9d248644
https://github.com/WebKit/WebKit/commit/081c4c12c5c5e20776b38bcd53856dfa9d248644
Author: Jer Noble <[email protected]>
Date: 2026-07-15 (Wed, 15 Jul 2026)
Changed paths:
M Source/WebCore/Configurations/AllowedSPI-legacy.toml
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/cocoa/WebAVPlayerLayerView.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm
Log Message:
-----------
[Cleanup] Add logging to WebAVPlayerLayerView
rdar://182253584
https://bugs.webkit.org/show_bug.cgi?id=319438
Reviewed by Eric Carlson.
Add Logging to WebAVPlayerLayerView by using logger information from
WebAVPlayerLayer.
But to do so with LoggerHelper, each C-style method implementation needs to
have a `self`
variable which the LoggerHelper macros can use to construct the log statement.
Update all
the methods signatures in WebAVPlayerLayerView.mm to declare a `self` parameter
for the
first parameter, whose type is the type of the underlying class. This makes the
code much
cleaner and easier to reason about, in addition to making LoggerHelper work.
* Source/WebCore/Configurations/AllowedSPI-legacy.toml:
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm:
(WebCore::WebAVPlayerLayerView_webPlayerLayer):
(WebCore::WebAVPlayerLayerView_transferVideoViewTo):
(WebCore::WebAVPlayerLayerView_playerController):
(WebCore::WebAVPlayerLayerView_setPlayerController):
(WebCore::WebAVPlayerLayerView_playerLayer):
(WebCore::WebAVPlayerLayerView_videoView):
(WebCore::WebAVPlayerLayerView_setVideoView):
(WebCore::WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
(WebCore::WebAVPlayerLayerView_stopRoutingVideoToPictureInPicturePlayerLayerView):
(WebCore::WebAVPlayerLayerView_pictureInPicturePlayerLayerView):
(WebCore::WebAVPlayerLayerView_dealloc):
(WebCore::WebAVPlayerLayerView_logIdentifier):
(WebCore::WebAVPlayerLayerView_loggerPtr):
(WebCore::WebAVPlayerLayerView_logChannel):
(WebCore::allocWebAVPlayerLayerViewInstance):
(WebCore::WebAVPictureInPicturePlayerLayerView_dealloc):
Canonical link: https://commits.webkit.org/317289@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
