Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c432d408c1757a45d4cdb53c2f1a7ab134ebd4c0
https://github.com/WebKit/WebKit/commit/c432d408c1757a45d4cdb53c2f1a7ab134ebd4c0
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-16 (Thu, 16 Jul 2026)
Changed paths:
M Source/WTF/wtf/HashFunctions.h
Log Message:
-----------
[WTF] IntPairHash::equal and DefaultHash<pair<int, unsigned>> use wrong
template arguments
https://bugs.webkit.org/show_bug.cgi?id=319519
Reviewed by Chris Dumez.
Two copy/paste typos in HashFunctions.h:
- IntPairHash<T, U>::equal delegated to PairHash<T, T> instead of
PairHash<T, U>, inconsistent with hash() and
safeToCompareToEmptyOrDeleted, which both use <T, U>. When T != U this
forced an implicit conversion of the pair's second element to T before
comparing.
- DefaultHash<std::pair<int, unsigned>> specialized IntPairHash<unsigned,
unsigned> rather than IntPairHash<int, unsigned>, the odd one out among
the integer-pair specializations that otherwise forward the pair's own
element types.
* Source/WTF/wtf/HashFunctions.h:
(WTF::IntPairHash::equal):
Canonical link: https://commits.webkit.org/317318@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
