Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f6eeb78cca650f29dd2649798fa25cb2a554928c
https://github.com/WebKit/WebKit/commit/f6eeb78cca650f29dd2649798fa25cb2a554928c
Author: Brent Fulgham <[email protected]>
Date: 2026-07-17 (Fri, 17 Jul 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-dialog-dismisses-unrelated-auto-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-dialog-dismisses-unrelated-auto.html
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-hierarchy-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute-hint-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-hint-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-manual-hide-does-not-close-auto-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-manual-hide-does-not-close-auto.html
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-in-beforetoggle-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-remove-attribute-during-focusing-steps-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-hints-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types-with-hints-expected.txt
M
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M
LayoutTests/platform/ios-18/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-hierarchy-expected.txt
M
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/DocumentFullscreen.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/PopoverData.h
M Source/WebCore/html/HTMLDialogElement.cpp
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/platform/CommonAtomStrings.h
Log Message:
-----------
Implement popover=hint
https://bugs.webkit.org/show_bug.cgi?id=275048
rdar://129495028
Reviewed by Anne van Kesteren and Ryosuke Niwa.
This change implements the popover='hint' feature. This is a small addition to
the
existing popover feature added in a previous cycle. The implementation matches
the
current specification and existing WPT expectations.
https://github.com/whatwg/html/pull/9778
https://open-ui.org/components/popover-hint.research.explainer/
Tested by existing imported/w3c/web-platform-tests/html/semantics/popovers test
suite.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-dialog-dismisses-unrelated-auto-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-dialog-dismisses-unrelated-auto.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-hierarchy-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute-hint-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-hint-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-manual-hide-does-not-close-auto-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-manual-hide-does-not-close-auto.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-in-beforetoggle-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-remove-attribute-during-focusing-steps-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-hints-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types-with-hints-expected.txt:
*
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
*
LayoutTests/platform/ios-18/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-hierarchy-expected.txt:
*
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::addPopoverToList):
(WebCore::Document::removePopoverFromList):
(WebCore::Document::addTopLayerElement):
(WebCore::Document::removeTopLayerElement):
(WebCore::Document::topmostHintPopover const):
(WebCore::Document::nearestOpenHintAncestor const):
(WebCore::Document::closeAllHintPopovers):
(WebCore::Document::closeHintPopoversUntil):
(WebCore::Document::hidePopoversForTopLayerElement):
(WebCore::Document::hideAutoPopoversUntil):
(WebCore::Document::handlePopoverLightDismiss):
(WebCore::Document::hideAllPopoversUntil):
* Source/WebCore/dom/Document.h:
(WebCore::Document::needsPointerEventHandlingForPopoverOrDialog const):
(WebCore::Document::isRunningPopoverShowOrHide const):
(WebCore::Document::PopoverShowOrHideScope::PopoverShowOrHideScope):
(WebCore::Document::PopoverShowOrHideScope::~PopoverShowOrHideScope):
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::elementEnterFullscreen):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::topmostPopoverAncestor):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/PopoverData.h:
(WebCore::PopoverData::showingAsHint const):
(WebCore::PopoverData::setShowingAsHint):
(WebCore::PopoverData::hintStackParent const):
(WebCore::PopoverData::setHintStackParent):
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::queuePopoverToggleEventTask):
(WebCore::HTMLElement::showPopover):
(WebCore::HTMLElement::showPopoverInternal):
(WebCore::HTMLElement::hidePopoverInternal):
(WebCore::HTMLElement::togglePopover):
(WebCore::HTMLElement::popoverAttributeChanged):
(WebCore::HTMLElement::popover const):
* Source/WebCore/platform/CommonAtomStrings.h:
Canonical link: https://commits.webkit.org/317402@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
