Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3a9487df981031613862461b927dd63456357289
https://github.com/WebKit/WebKit/commit/3a9487df981031613862461b927dd63456357289
Author: Alan Baradlay <[email protected]>
Date: 2026-07-18 (Sat, 18 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexLayout.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[cleanup] Fold minimumHeightForLineIfEmpty into
updateFlexContainerLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=318674
Reviewed by Antti Koivisto.
minimumHeightForLineIfEmpty had a single caller,
updateFlexContainerLogicalHeight, which already computes
the container's logical height in one std::max. Inline it there (compute the
empty-line minimum from
hasLineIfEmpty right where it feeds the max) and remove the standalone method
and its declaration.
While here, tidy the FlexLayout content pipeline: size
flexLinesCrossPositionList at its declaration (the
flex lines are already collected by performContentSizing before it, so the
separate assignment inside
computeFlexLineCrossPositions was redundant), and drop the blank lines between
the steps in
performContentAlignment so it reads like performContentSizing.
No change in behavior.
* Source/WebCore/rendering/RenderFlexLayout.cpp:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(RenderFlexibleBox::updateFlexContainerLogicalHeight):
* Source/WebCore/rendering/RenderFlexibleBox.h:
Canonical link: https://commits.webkit.org/317477@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
