Diff
Modified: trunk/Source/WebCore/ChangeLog (115371 => 115372)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 21:40:14 UTC (rev 115372)
@@ -1,3 +1,32 @@
+2012-04-26 Kentaro Hara <[email protected]>
+
+ [V8] Pass Isolate to wrap() (Part2)
+ https://bugs.webkit.org/show_bug.cgi?id=84922
+
+ Reviewed by Nate Chapin.
+
+ The objective is to pass Isolate around in V8 bindings.
+ This patch passes Isolate to wrap() in custom bindings.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8SVGPathSegCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8StyleSheetCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint16ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint32ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint8ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
+ (WebCore::toV8):
+
2012-04-26 Jon Lee <[email protected]>
[WK2] AlternativeTextClient leaks when the page is destroyed
Modified: trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -278,7 +278,7 @@
return v8::Null();
v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
if (wrapper.IsEmpty()) {
- wrapper = V8Location::wrap(impl);
+ wrapper = V8Location::wrap(impl, isolate);
if (!wrapper.IsEmpty())
V8DOMWrapper::setNamedHiddenWindowReference(impl->frame(), "location", wrapper);
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -75,7 +75,7 @@
{
if (!impl)
return v8::Null();
- v8::Handle<v8::Object> wrapper = V8NamedNodeMap::wrap(impl);
+ v8::Handle<v8::Object> wrapper = V8NamedNodeMap::wrap(impl, isolate);
// Add a hidden reference from named node map to its owner node.
Element* element = impl->element();
if (!wrapper.IsEmpty() && element)
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -102,7 +102,7 @@
return toV8(static_cast<SVGPathSegCurvetoQuadraticSmoothRel*>(impl), isolate);
}
ASSERT_NOT_REACHED();
- return V8SVGPathSeg::wrap(impl);
+ return V8SVGPathSeg::wrap(impl, isolate);
}
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -43,7 +43,7 @@
return v8::Null();
if (impl->isCSSStyleSheet())
return toV8(static_cast<CSSStyleSheet*>(impl), isolate);
- v8::Handle<v8::Object> wrapper = V8StyleSheet::wrap(impl);
+ v8::Handle<v8::Object> wrapper = V8StyleSheet::wrap(impl, isolate);
// Add a hidden reference from stylesheet object to its owner node.
Node* ownerNode = impl->ownerNode();
if (ownerNode && !wrapper.IsEmpty())
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint16ArrayCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint16ArrayCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint16ArrayCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -57,7 +57,7 @@
{
if (!impl)
return v8::Null();
- v8::Handle<v8::Object> wrapper = V8Uint16Array::wrap(impl);
+ v8::Handle<v8::Object> wrapper = V8Uint16Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalUnsignedShortArray, impl->length());
return wrapper;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint32ArrayCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint32ArrayCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint32ArrayCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -57,7 +57,7 @@
{
if (!impl)
return v8::Null();
- v8::Handle<v8::Object> wrapper = V8Uint32Array::wrap(impl);
+ v8::Handle<v8::Object> wrapper = V8Uint32Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalUnsignedIntArray, impl->length());
return wrapper;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint8ArrayCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint8ArrayCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint8ArrayCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -57,7 +57,7 @@
{
if (!impl)
return v8::Null();
- v8::Handle<v8::Object> wrapper = V8Uint8Array::wrap(impl);
+ v8::Handle<v8::Object> wrapper = V8Uint8Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalUnsignedByteArray, impl->length());
return wrapper;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp (115371 => 115372)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp 2012-04-26 21:37:42 UTC (rev 115371)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp 2012-04-26 21:40:14 UTC (rev 115372)
@@ -54,7 +54,7 @@
{
if (!impl)
return v8::Null();
- v8::Handle<v8::Object> wrapper = V8Uint8ClampedArray::wrap(impl);
+ v8::Handle<v8::Object> wrapper = V8Uint8ClampedArray::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalPixelArray, impl->length());
return wrapper;
