Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e975af100db2250a0b2db79525a312d6bce2d078
https://github.com/WebKit/WebKit/commit/e975af100db2250a0b2db79525a312d6bce2d078
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-19 (Sun, 19 Jul 2026)
Changed paths:
M Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
Log Message:
-----------
Web Inspector: SourcesNavigationSidebarPanel leaks an anonymous WI.SourceCode
listener on every panel recreation
https://bugs.webkit.org/show_bug.cgi?id=319773
rdar://182630536
Reviewed by Devin Rousso.
SourcesNavigationSidebarPanel registered an inline anonymous function as a
listener on the static WI.SourceCode event target instead of a named,
bound instance method. Because the closure was never stored anywhere,
listener on the static WI.SourceCode event target instead of a named,
bound instance method. Because the closure was never stored anywhere,
closed() had no way to remove it, so every panel instance leaked its
listener (and the panel itself, transitively) each time the panel was
recreated.
* Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype.closed):
(WI.SourcesNavigationSidebarPanel.prototype._handleSourceCodeSourceMapAdded):
Canonical link: https://commits.webkit.org/317519@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
