Title: [115375] trunk/Source/WebCore
- Revision
- 115375
- Author
- [email protected]
- Date
- 2012-04-26 14:56:23 -0700 (Thu, 26 Apr 2012)
Log Message
Use String instead of RefPtr<StringImpl> for the cache of ObjcClass
https://bugs.webkit.org/show_bug.cgi?id=84932
Patch by Benjamin Poulain <[email protected]> on 2012-04-26
Reviewed by Andreas Kling.
The cache with RefPtr<StringImpl*> was added with r115007.
This patch aims at making the code a little easier to read. By using String,
one would not need to know the Traits for StringImpl.
* bridge/objc/objc_class.h:
(ObjcClass):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (115374 => 115375)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 21:53:18 UTC (rev 115374)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 21:56:23 UTC (rev 115375)
@@ -1,3 +1,18 @@
+2012-04-26 Benjamin Poulain <[email protected]>
+
+ Use String instead of RefPtr<StringImpl> for the cache of ObjcClass
+ https://bugs.webkit.org/show_bug.cgi?id=84932
+
+ Reviewed by Andreas Kling.
+
+ The cache with RefPtr<StringImpl*> was added with r115007.
+
+ This patch aims at making the code a little easier to read. By using String,
+ one would not need to know the Traits for StringImpl.
+
+ * bridge/objc/objc_class.h:
+ (ObjcClass):
+
2012-04-26 Kentaro Hara <[email protected]>
[V8] Pass Isolate to wrap() in SerializedScriptValue.cpp
Modified: trunk/Source/WebCore/bridge/objc/objc_class.h (115374 => 115375)
--- trunk/Source/WebCore/bridge/objc/objc_class.h 2012-04-26 21:53:18 UTC (rev 115374)
+++ trunk/Source/WebCore/bridge/objc/objc_class.h 2012-04-26 21:56:23 UTC (rev 115375)
@@ -27,6 +27,7 @@
#define KJS_BINDINGS_OBJC_CLASS_H
#include "objc_runtime.h"
+#include <wtf/text/WTFString.h>
namespace JSC {
namespace Bindings {
@@ -50,7 +51,7 @@
private:
ClassStructPtr _isa;
RetainPtr<CFMutableDictionaryRef> _methods;
- mutable HashMap<RefPtr<StringImpl>, OwnPtr<Field> > m_fieldCache;
+ mutable HashMap<String, OwnPtr<Field> > m_fieldCache;
};
} // namespace Bindings
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
