Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 436208095697b206723e6b6e30776368ff967ce9
https://github.com/WebKit/WebKit/commit/436208095697b206723e6b6e30776368ff967ce9
Author: Aakash Jain <[email protected]>
Date: 2026-07-21 (Tue, 21 Jul 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Refactor AnalyzeAPITestsResults to read build properties like layout
tests
https://bugs.webkit.org/show_bug.cgi?id=319898
rdar://problem/182817323
Reviewed by Ryan Haddad.
AnalyzeAPITestsResults re-fetches and re-parses the json log of each API test
run step from the database,
instead of reading the failure lists that the run steps already computed and
stored as build properties.
This also created various inefficiencies and edge cases bugs.
For layout-tests we use a much better approach, AnalyzeLayoutTestsResults reads
first_run_failures /
second_run_failures / clean_tree_run_failures directly as properties.
This improves AnalyzeAPITestsResults to use the same pattern.
* Tools/CISupport/ews-build/steps.py:
(RunAPITests.run): Parse and publish failures, then run results-db analysis.
(RunAPITests.parse_and_set_failures): Added; parse the json log and set
{suffix}_failures.
(RunAPITests.analyze_failures_using_results_db): Now takes the parsed failures
and only does
results-db filtering.
(RunAPITestsWithoutChange): Set suffix to 'clean_tree_run' so
parse_and_set_failures publishes
clean_tree_run_failures; skip results-db filtering.
(RunAPITestsParallelSafety.analyze_failures_using_results_db): Match the new
signature.
(AnalyzeAPITestsResults.run): Read failure lists from build properties; merge
the former
analyzeResults logic in and drop the redundant json re-parsing.
(AnalyzeAPITestsResults.analyzeResults): Removed; folded into run.
(AnalyzeAPITestsResults.getBuildStepByName): Removed; no longer needed.
(AnalyzeAPITestsResults.getTestsResults): Removed; no longer needed.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestAnalyzeAPITestsResults): Added.
Canonical link: https://commits.webkit.org/317641@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
