Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b560bf8e54109b9e46d737bf1c4b0d90324f6401
https://github.com/WebKit/WebKit/commit/b560bf8e54109b9e46d737bf1c4b0d90324f6401
Author: Ryan Haddad <[email protected]>
Date: 2026-07-21 (Tue, 21 Jul 2026)
Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/classify_unittest.py
M
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py
M metadata/commit_classes.json
Log Message:
-----------
[webkitscmpy] Changes to tests shouldn't be considered "Gardening"
https://bugs.webkit.org/show_bug.cgi?id=319847
rdar://182469134
Reviewed by Aakash Jain.
The "Gardening" commit class matched any change whose files were all located in
LayoutTests,
so a PR that fixed test code would be classified as "Gardening", resulting in
git-webkit
commenting as much in the associated bugzilla. Beyond potential confusion, it
could also result
in silently skipping bug assignment and reopening.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/classify_unittest.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
* metadata/commit_classes.json: Narrow the Gardening paths so a gardening
change may only
touch test expectations and baseline/result files, never a test driver. A
change that edits
an actual test now falls through to the Tools class and is handled like any
other pull request.
Pure skip and rebaseline changes continue to be classified as Gardening.
Canonical link: https://commits.webkit.org/317644@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
