Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fddb5a3c6e47dc89ee2025089f5fe47dc030d733
https://github.com/WebKit/WebKit/commit/fddb5a3c6e47dc89ee2025089f5fe47dc030d733
Author: Issac Roy <[email protected]>
Date: 2026-07-21 (Tue, 21 Jul 2026)
Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
M
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py
Log Message:
-----------
[git-webkit] `git-webkit pr` should warn before posting an un-reviewed PR
with a "Reviewed-by" line
https://bugs.webkit.org/show_bug.cgi?id=293152
rdar://151488850
Reviewed by Sam Sneddon.
If a PR claims to be "Un-reviewed" (with no dash) or "Version-ing"
(with no dash) but includes a "Reviewed-by" line, warn the user and
prompt to automatically remove the "Reviewed-by" line in the case of a
single commit or manually fix it in the case of multiple commits.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_pull_request):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
Canonical link: https://commits.webkit.org/317647@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
