Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1406a9ebc32d5aebb56b987141810590c0b4270d
https://github.com/WebKit/WebKit/commit/1406a9ebc32d5aebb56b987141810590c0b4270d
Author: Zak Ridouh <[email protected]>
Date: 2026-07-21 (Tue, 21 Jul 2026)
Changed paths:
M Source/JavaScriptCore/runtime/VM.h
Log Message:
-----------
Export VM::hasLanguageChange() so WebCore can link against it
https://bugs.webkit.org/show_bug.cgi?id=319925
rdar://182851292
Reviewed by Keith Miller.
r8d261de036d4 ("Cache Intl.DateTimeFormat") changed the inline
VM::hasAnyEntryScopeServiceRequest() to call the out-of-line
VM::hasLanguageChange(), but that declaration was never marked
JS_EXPORT_PRIVATE. hasLanguageChange() must stay out-of-line because
IntlCache is only forward-declared in VM.h, so its symbol stayed hidden
in the JavaScriptCore dylib. WebCore inlines
hasAnyEntryScopeServiceRequest(), needs the symbol, and failed to link:
Undefined symbols for architecture arm64:
"JSC::VM::hasLanguageChange()", referenced from:
JSC::VM::hasAnyEntryScopeServiceRequest() in
WebCoreJSBindings_pch_obj.cpp.o
Mark the declaration JS_EXPORT_PRIVATE so it is exported, matching the
other out-of-line VM methods reached from inline header callers.
* Source/JavaScriptCore/runtime/VM.h:
Canonical link: https://commits.webkit.org/317663@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
