Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 689509d66dd53e195d05c56683f1dcaae2ae3870
https://github.com/WebKit/WebKit/commit/689509d66dd53e195d05c56683f1dcaae2ae3870
Author: Basuke Suzuki <[email protected]>
Date: 2026-07-21 (Tue, 21 Jul 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any.serviceworker-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any.sharedworker-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any.worker-expected.txt
M Source/WebCore/Modules/webtransport/WebTransport.cpp
M Source/WebCore/Modules/webtransport/WebTransportSendStream.cpp
M Source/WebCore/Modules/webtransport/WebTransportSendStream.h
Log Message:
-----------
[WebTransport] WebTransportSendStream should reflect sendOrder and sendGroup
from creation options
https://bugs.webkit.org/show_bug.cgi?id=319875
rdar://161685860
Reviewed by Alex Christensen.
WebTransport::createBidirectionalStream and createUnidirectionalStream
discarded their
WebTransportSendStreamOptions argument, so the sendOrder and sendGroup supplied
at stream
creation never reached the resulting WebTransportSendStream. As a result
writable.sendOrder
did not reflect the value passed to createBidirectionalStream({sendOrder: N}).
Thread the creation options into WebTransportSendStream::create so the created
stream reflects
the requested sendOrder (defaulting to 0) and sendGroup, propagating the
sendGroup
transport-ownership check. Server-initiated streams keep the default (sendOrder
0, no group).
This is the WebCore/attribute-level part; actual wire-level send scheduling is
tracked
separately in rdar://161685860.
This unskips
imported/w3c/web-platform-tests/webtransport/sendorder.https.any.*, which now
pass (all three subtests, across the window/worker/serviceworker/sharedworker
variants).
* LayoutTests/TestExpectations: Unskip the sendorder tests and drop sendOrder
from the
backend-gaps comment.
*
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any.serviceworker-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any.sharedworker-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/webtransport/sendorder.https.any.worker-expected.txt:
* Source/WebCore/Modules/webtransport/WebTransport.cpp:
(WebCore::createBidirectionalStream):
(WebCore::WebTransport::createBidirectionalStream):
(WebCore::WebTransport::createUnidirectionalStream):
* Source/WebCore/Modules/webtransport/WebTransportSendStream.cpp:
(WebCore::WebTransportSendStream::create):
* Source/WebCore/Modules/webtransport/WebTransportSendStream.h:
Canonical link: https://commits.webkit.org/317665@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
