Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fd5b5997ff3424e7fdc0be8e451d8ed1bd59a379
https://github.com/WebKit/WebKit/commit/fd5b5997ff3424e7fdc0be8e451d8ed1bd59a379
Author: Alex Christensen <[email protected]>
Date: 2026-07-24 (Fri, 24 Jul 2026)
Changed paths:
M Source/WebCore/Modules/webtransport/WebTransport.cpp
M Source/WebCore/Modules/webtransport/WebTransport.h
M Source/WebCore/Modules/webtransport/WebTransportDatagramDuplexStream.cpp
M Source/WebCore/Modules/webtransport/WebTransportDatagramsWritable.cpp
M
Source/WebCore/Modules/webtransport/WebTransportReceiveStreamByteSource.cpp
M Source/WebCore/Modules/webtransport/WebTransportSendGroup.cpp
M Source/WebCore/Modules/webtransport/WebTransportSendStream.cpp
M Source/WebCore/Modules/webtransport/WebTransportSendStreamSink.cpp
M Source/WebCore/Modules/webtransport/WebTransportSession.h
M Source/WebCore/Modules/webtransport/WorkerWebTransportSession.cpp
M Source/WebCore/Modules/webtransport/WorkerWebTransportSession.h
M Source/WebCore/dom/Document.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyClients.h
M Source/WebCore/page/SocketProvider.h
M Source/WebKit/WebProcess/Network/WebSocketProvider.cpp
M Source/WebKit/WebProcess/Network/WebSocketProvider.h
M Source/WebKit/WebProcess/Network/WebTransportSession.cpp
M Source/WebKit/WebProcess/Network/WebTransportSession.h
M Source/WebKitLegacy/WebCoreSupport/LegacySocketProvider.cpp
M Source/WebKitLegacy/WebCoreSupport/LegacySocketProvider.h
Log Message:
-----------
Make WebTransport's session a Ref instead of a RefPtr
https://bugs.webkit.org/show_bug.cgi?id=320161
rdar://183095821
Reviewed by Basuke Suzuki.
This removes unneeded null checks and makes the code more consistent.
Everything the WebTransportSession does that returns something uses
NativePromise
the same way now. I initially made WebTransportSession able to be disconnected
when the connection terminates, but now that we need it around for getStats
after connection termination, we may as well make it a const Ref.
* Source/WebCore/Modules/webtransport/WebTransport.cpp:
(WebCore::WebTransport::create):
(WebCore::clientOrigin):
(WebCore::WebTransport::WebTransport):
(WebCore::WebTransport::receiveIncomingUnidirectionalStream):
(WebCore::WebTransport::receiveBidirectionalStream):
(WebCore::WebTransport::streamReceiveError):
(WebCore::WebTransport::streamSendError):
(WebCore::WebTransport::getStats):
(WebCore::WebTransport::exportKeyingMaterial):
(WebCore::WebTransport::cleanupContext):
(WebCore::WebTransport::close):
(WebCore::WebTransport::createBidirectionalStream):
(WebCore::WebTransport::createUnidirectionalStream):
(WebCore::WebTransport::initializeOverHTTP): Deleted.
(WebCore::WebTransport::session):
* Source/WebCore/Modules/webtransport/WebTransport.h:
(WebCore::WebTransport::session const):
* Source/WebCore/Modules/webtransport/WebTransportDatagramDuplexStream.cpp:
(WebCore::WebTransportDatagramDuplexStream::session):
* Source/WebCore/Modules/webtransport/WebTransportDatagramsWritable.cpp:
(WebCore::WebTransportDatagramsWritable::create):
* Source/WebCore/Modules/webtransport/WebTransportReceiveStreamByteSource.cpp:
(WebCore::WebTransportReceiveStreamByteSource::cancel):
* Source/WebCore/Modules/webtransport/WebTransportSendGroup.cpp:
(WebCore::WebTransportSendGroup::getStats):
* Source/WebCore/Modules/webtransport/WebTransportSendStream.cpp:
(WebCore::WebTransportSendStream::getStats):
* Source/WebCore/Modules/webtransport/WebTransportSendStreamSink.cpp:
(WebCore::WebTransportSendStreamSink::write):
(WebCore::WebTransportSendStreamSink::close):
(WebCore::WebTransportSendStreamSink::abort):
* Source/WebCore/Modules/webtransport/WebTransportSession.h:
* Source/WebCore/Modules/webtransport/WorkerWebTransportSession.cpp:
(WebCore::WorkerWebTransportSession::initialize):
* Source/WebCore/Modules/webtransport/WorkerWebTransportSession.h:
* Source/WebCore/dom/Document.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::emptySocketProvider):
(WebCore::pageConfigurationWithEmptyClients):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/SocketProvider.h:
* Source/WebKit/WebProcess/Network/WebSocketProvider.cpp:
(WebKit::WebSocketProvider::createWebTransportSession):
(WebKit::WebSocketProvider::initializeWebTransportSession): Deleted.
* Source/WebKit/WebProcess/Network/WebSocketProvider.h:
* Source/WebKit/WebProcess/Network/WebTransportSession.cpp:
(WebKit::WebTransportSession::create):
(WebKit::WebTransportSession::WebTransportSession):
(WebKit::WebTransportSession::initialize):
* Source/WebKit/WebProcess/Network/WebTransportSession.h:
* Source/WebKitLegacy/WebCoreSupport/LegacySocketProvider.cpp:
(LegacySocketProvider::createWebTransportSession):
(LegacySocketProvider::initializeWebTransportSession): Deleted.
* Source/WebKitLegacy/WebCoreSupport/LegacySocketProvider.h:
Canonical link: https://commits.webkit.org/317885@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
