Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4a74cec87d6df520ffb556bc0a488cf9e195c118
https://github.com/WebKit/WebKit/commit/4a74cec87d6df520ffb556bc0a488cf9e195c118
Author: Zak Ridouh <[email protected]>
Date: 2026-07-24 (Fri, 24 Jul 2026)
Changed paths:
M Source/WTF/Scripts/generate-platform-args
M Source/WebCore/CMakeLists.txt
M Source/WebCore/WebCoreMacros.cmake
M Source/WebCore/bindings/scripts/generate-bindings-all.pl
M Source/WebCore/css/make-css-file-arrays.pl
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/css/scripts/process-css-pseudo-selectors.py
M Source/WebCore/css/scripts/process-css-values.py
M Source/cmake/OptionsCocoa.cmake
M Source/cmake/OptionsMac.cmake
M Source/cmake/WebKitFeatures.cmake
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[CMake] Derive the generators' feature defines from Platform.h on Mac
<https://bugs.webkit.org/show_bug.cgi?id=312033>
<rdar://problem/182231103>
Reviewed by Elliott Williams.
The IDL/CSS/bindings generators got their feature --defines from the CMake
option list, which hand-mirrored SDK-gated PlatformEnableCocoa.h features (the
ENABLE_APPLE_PAY_* family and friends) and drifted from what the compiler sees
through wtf/Platform.h.
Make Platform.h the source of truth, like Xcode's DerivedSources.make: retire
those options from the Mac port, since their value depends on the SDK and so
isn't knowable at configure time, and derive the generators' defines by
preprocessing Platform.h at build time, passing them via a new --defines-file.
Mac-only for now.
* Source/WTF/Scripts/generate-platform-args:
(run_clang_command):
(run_cmake_mode):
(write_if_changed):
(run_print_feature_defines_mode):
(main):
* Source/cmake/OptionsCocoa.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
(WEBKIT_OPTION_OWNED_BY_PLATFORM_H):
* Source/cmake/WebKitMacros.cmake:
(_webkit_platform_args_empty_input):
(_webkit_platform_args_clang_prefix):
(webkit_generate_platform_feature_defines_file):
(_webkit_generate_platform_swift_args):
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/WebCoreMacros.cmake:
* Source/WebCore/bindings/scripts/generate-bindings-all.pl:
* Source/WebCore/css/make-css-file-arrays.pl:
* Source/WebCore/css/scripts/process-css-properties.py:
* Source/WebCore/css/scripts/process-css-pseudo-selectors.py:
* Source/WebCore/css/scripts/process-css-values.py:
Canonical link: https://commits.webkit.org/317916@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
