Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f67b7993605d66a0198231ba0de8a056bdf1ed9d
https://github.com/WebKit/WebKit/commit/f67b7993605d66a0198231ba0de8a056bdf1ed9d
Author: Jer Noble <[email protected]>
Date: 2026-07-27 (Mon, 27 Jul 2026)
Changed paths:
M Source/WebCore/Modules/modern-media-controls/media/YouTubeCaptionQuirk.js
Log Message:
-----------
REGRESSION(316238@main): YouTube captions become infinitely tall in iPhone
fullscreen
rdar://182808868
https://bugs.webkit.org/show_bug.cgi?id=320374
Reviewed by Simon Fraser.
In 316238@main, in order to work around an issue where both YouTube's
custom-rendered
subtitles and quirk-derived system subtitles were displayed simultanously,
YouTube's
own subtitle divs were hidden with `display:none`. However this broke their
ability to
detect that subtitles have grown too tall inside the video viewport, and they
fail to
remove those generated subtitles when adding new ones.
Switch from `display:none` to `visibility:hidden` so that size detection works
the way
YouTube expects, even though the subtitles are not displayed.
* Source/WebCore/Modules/modern-media-controls/media/YouTubeCaptionQuirk.js:
(CaptionMirror.prototype._handlePresentationModeChanged):
Canonical link: https://commits.webkit.org/317999@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
