Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b644eadfe2244bdf01c08b31d4a5952cbb8c8fe0
https://github.com/WebKit/WebKit/commit/b644eadfe2244bdf01c08b31d4a5952cbb8c8fe0
Author: Richard Robinson <[email protected]>
Date: 2026-07-27 (Mon, 27 Jul 2026)
Changed paths:
A
LayoutTests/http/tests/site-isolation/provisional-frame-networking-context-expected.txt
A
LayoutTests/http/tests/site-isolation/provisional-frame-networking-context.html
A
LayoutTests/http/tests/site-isolation/resources/report-networking-context-validity.html
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/cocoa/WebFrameNetworkingContext.h
M Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp
M Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.h
M Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
M Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h
Log Message:
-----------
[Site Isolation] A cross-site frame's FrameNetworkingContext is never valid,
silently dropping in-process loads
https://bugs.webkit.org/show_bug.cgi?id=320279
rdar://183196588
Reviewed by Alex Christensen.
Use the LocalFrame that owns the client rather than WebFrame::coreLocalFrame().
During a
cross-site provisional load under site isolation, the WebFrame still points at
the RemoteFrame
it will replace, so coreLocalFrame() is null and the context would never become
valid.
Test: http/tests/site-isolation/provisional-frame-networking-context.html
*
LayoutTests/http/tests/site-isolation/provisional-frame-networking-context-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/provisional-frame-networking-context.html:
Added.
*
LayoutTests/http/tests/site-isolation/resources/report-networking-context-validity.html:
Added.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::frameNetworkingContextIsValid const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::createNetworkingContext):
* Source/WebKit/WebProcess/WebCoreSupport/cocoa/WebFrameNetworkingContext.h:
(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
* Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
* Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.h:
(WebKit::WebFrameNetworkingContext::create):
* Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
* Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
(WebKit::WebFrameNetworkingContext::create):
Canonical link: https://commits.webkit.org/318038@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
