Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 17afba52f935e236c57013631ed39f83e5c4668d
https://github.com/WebKit/WebKit/commit/17afba52f935e236c57013631ed39f83e5c4668d
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-28 (Tue, 28 Jul 2026)
Changed paths:
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
Log Message:
-----------
LibWebRTCAudioModule has a data race on m_isPlaying and m_audioTransport
https://bugs.webkit.org/show_bug.cgi?id=320113
rdar://183054655
Reviewed by Youenn Fablet.
m_isPlaying and m_audioTransport are written from StartPlayout(),
StopPlayout(), and RegisterAudioCallback() — called from libwebrtc's
callback threads — and read from pollAudioData()/pollFromSource() on
the internal WorkQueue thread, as well as from Playing(), with no
lock or atomic. Make both members std::atomic to close the race.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
(WebCore::LibWebRTCAudioModule::StartPlayout):
(WebCore::LibWebRTCAudioModule::StopPlayout):
(WebCore::LibWebRTCAudioModule::pollFromSource):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
Canonical link: https://commits.webkit.org/318047@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
