Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2a2036f697b145ad90e29dd24dfc94502f0068bb
https://github.com/WebKit/WebKit/commit/2a2036f697b145ad90e29dd24dfc94502f0068bb
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-28 (Tue, 28 Jul 2026)
Changed paths:
M Source/WebCore/Modules/webaudio/AudioParam.cpp
Log Message:
-----------
AudioParam::finalValue() returns an uninitialized float when
calculateFinalValues() bails out
https://bugs.webkit.org/show_bug.cgi?id=320375
rdar://183342212
Reviewed by Chris Dumez.
finalValue() declared `float value;` uninitialized and relied on
calculateFinalValues()
to write it, but that function early-returns without touching the output span
when there
is no context, we are off the audio thread, or the span is empty. The garbage
value then
flows into DSP as an oscillator frequency, filter cutoff, delay time, pan,
compressor
threshold, etc.
Initialize `value` to m_value, which is always set from defaultValue in the
constructor.
The k-rate path fills the span with m_value anyway, so this only changes the
previously-garbage path.
No new test.
* Source/WebCore/Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::finalValue):
Canonical link: https://commits.webkit.org/318052@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
