Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2d50d7a754c72cf9ef44a64254bcf2b4e9d3b22d
https://github.com/WebKit/WebKit/commit/2d50d7a754c72cf9ef44a64254bcf2b4e9d3b22d
Author: Brady Eidson <[email protected]>
Date: 2026-07-28 (Tue, 28 Jul 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
Add tests verifying cross-origin iframe window.alert() behavior
rdar://182962288
https://bugs.webkit.org/show_bug.cgi?id=320028
Reviewed by Alex Christensen.
JavaScript dialog APIs (i.e. window.alert(), etc) currently work well with site
isolation on.
These tests verify they continue to work well.
One notable difference with site isolation is that a cross-origin iframe stuck
in a JS dialog no longer
blocks the main frame. This is web compatible and suggested by the specs. And
these tests also confirm
that behavior remains as expected.
*
LayoutTests/http/tests/site-isolation/javascript-dialogs-in-cross-origin-iframe-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/javascript-dialogs-in-cross-origin-iframe.html:
Added.
*
LayoutTests/http/tests/site-isolation/resources/javascript-dialogs-iframe.html:
Added.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::testCrossSiteIframeCanShowAlert):
(TestWebKitAPI::TEST(SiteIsolation,
CrossSiteIframeCanShowAlertWithSiteIsolation)):
(TestWebKitAPI::TEST(SiteIsolation,
CrossSiteIframeCanShowAlertWithoutSiteIsolation)):
(TestWebKitAPI::TEST(SiteIsolation,
MainFrameHeartbeatContinuesWhileCrossSiteIframeDialogShown)):
Canonical link: https://commits.webkit.org/318073@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
