Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2dbe57d1dccf76b432c5381202d574d350af844c
https://github.com/WebKit/WebKit/commit/2dbe57d1dccf76b432c5381202d574d350af844c
Author: Issac Roy <[email protected]>
Date: 2026-07-28 (Tue, 28 Jul 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
Log Message:
-----------
The check for Reviewed-by should check at the start of the line
https://bugs.webkit.org/show_bug.cgi?id=319918
rdar://182840873
Reviewed by Sam Sneddon.
The validate-commit-message EWS step and the pull-request pre-check
both matched Reviewed-by anywhere in the commit message body, causing
false positives when the body text mentions Reviewed-by as a phrase
(e.g. a commit message that describes
the feature itself).
In the EWS step, `git log` without `--format=%B` indents commit message
lines with 4 spaces, so a `^` anchor in grep would not work. Switch to
`--format=%B` to get the raw message without indentation, then add the
`^` anchor to the grep patterns so only lines that start with a reviewer
string are matched.
In the pull-request check, replace the plain `Reviewed-by in message`
string search with a regex anchored to the start of a line.
* Tools/CISupport/ews-build/steps.py:
(ValidateCommitMessage.run): Use --format=%B and ^ in grep so reviewer
strings are only matched at the start of a line.
* Tools/CISupport/ews-build/steps_unittest.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_pull_request): Use an anchored regex instead of a
plain substring check for Reviewed-by.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.REVIEWED_BY_RE): Anchor to start of line.
Canonical
link:
https://flagged.apple.com:443/proxy?t2=Dk3n7H0Qg8&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE4MDkxQG1haW4=&emid=cbccfb51-2194-4595-af6e-5f575617daf9&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
