Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 81347effc2a82d24c89222190079a6dbe7315ac1
https://github.com/WebKit/WebKit/commit/81347effc2a82d24c89222190079a6dbe7315ac1
Author: Zak Ridouh <[email protected]>
Date: 2026-07-28 (Tue, 28 Jul 2026)
Changed paths:
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.mm
M Source/WebKit/Platform/cocoa/LayerHostingContextManager.mm
Log Message:
-----------
[CMake][Cocoa] Import BrowserEngineKit headers where BELayerHierarchy is used
https://bugs.webkit.org/show_bug.cgi?id=320505
rdar://183469399
Reviewed by Elliott Williams.
LayerHostingContextManager.mm and RemoteSampleBufferDisplayLayer.mm call
-addLayerHierarchy: and -commit on a
BELayerHierarchyHostingTransactionCoordinator,
but LayerHostingContext.h only forward-declares that class. Both files were
getting the declarations from a unified source bundle neighbor,
LayerHostingContext.mm, which imports the BrowserEngineKit headers itself.
Merging the Mac and iOS ports into Cocoa in 318097@main shifted the unified
bundle boundaries and split LayerHostingContextManager.mm off from
LayerHostingContext.mm, breaking the iOS CMake build with -Wobjc-method-access.
RemoteSampleBufferDisplayLayer.mm still builds today, but is fragile for the
same
reason.
Import the headers both files actually depend on instead of relying on bundle
layout.
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.mm:
* Source/WebKit/Platform/cocoa/LayerHostingContextManager.mm:
Canonical link: https://commits.webkit.org/318120@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
