Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 73a527b95f75436dc62313d444d4d9a086308fd9
https://github.com/WebKit/WebKit/commit/73a527b95f75436dc62313d444d4d9a086308fd9
Author: Carlos Garcia Campos <[email protected]>
Date: 2026-07-29 (Wed, 29 Jul 2026)
Changed paths:
M Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.cpp
M Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.h
Log Message:
-----------
[GTK][WPE] Skia compositor: remove effectiveLayerRect()
https://bugs.webkit.org/show_bug.cgi?id=320528
Reviewed by Alejandro G. Castro.
This was copied from texture mapper which means a different thing only
used for 3D context layers. In skia compositor it's always just
returning the layer rectangle. The layer rectangle is in layer
coordinates, so it's always 0,0 widthxheight. We have a member for the
size and build a FloatRect every time the layer rect is needed. This
patch replaces m_size by m_rect so that we always have the rectangle and
we just change its size when the layer size changes. We don't even need
a getter for the layer rect since it's only used internally.
* Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.cpp:
(WebCore::SkiaCompositingLayer::setSize):
(WebCore::SkiaCompositingLayer::updateBackingStore):
(WebCore::SkiaCompositingLayer::paintedLayerRect const):
(WebCore::SkiaCompositingLayer::computeTransformsAndAnimations):
(WebCore::SkiaCompositingLayer::paint):
(WebCore::SkiaCompositingLayer::paintSelfAndChildren):
(WebCore::SkiaCompositingLayer::isVisible const):
(WebCore::SkiaCompositingLayer::maskImage):
(WebCore::SkiaCompositingLayer::computeOverlapRegions):
(WebCore::SkiaCompositingLayer::transformedFlattenedBounds const):
(WebCore::SkiaCompositingLayer::geometryFor3DRenderingContext const):
* Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.h:
Canonical link: https://commits.webkit.org/318138@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications