Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: da58bb4f55b16310af446902cf4d58e7f97fcf74
https://github.com/WebKit/WebKit/commit/da58bb4f55b16310af446902cf4d58e7f97fcf74
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-07-29 (Wed, 29 Jul 2026)
Changed paths:
A Tools/Scripts/webkitpy/api_tests/glib_api_test_runner_unittest.py
M Tools/glib/api_test_runner.py
Log Message:
-----------
REGRESSION(317233@main): REGRESSION(317226@main): [GLIB] API test names
reported in --json-output don't match the names reported to results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=320499
Reviewed by Carlos Garcia Campos.
317226@main removed the port subdirectory from being part of the name uploaded
to results.webkit.org, and 317233@main made Google Test cases use a dot like
the Mac ports do. However, neither updated --json-output, which still uses the
old names.
This causes problems on the EWS for API tests on GTK and WPE, when there are
failures on a run it tries to consult resuls.webkit.org to see if the failure
is pre-existent but for that query it uses the test names as reported in the
json file, and those names don't match anymore.
Fix that by ensuring that the names used for the tests stay consistent both in
--json-output as well as on the names used for the upload to results.webkit.org
When running tests accept as argument for the test to run both a binary path
(full
or relative) on the command line as well as the bare name with the port
subdirectory
removed. So the previous naming still works to specify tests to run even when
the
name of the tests reported uses the bare name everywhere now.
Also added unit tests to verify this works as expected and doesn't regress,
including also round trip testing from the canonical names written to
--json-output
back to the command-line runner.
* Tools/Scripts/webkitpy/api_tests/glib_api_test_runner_unittest.py: Added.
(StubTestRunner):
(StubTestRunner.__init__):
(StubTestRunner._test_programs_base_dir):
(StubTestRunner.is_google_test):
(GLibAPITestRunnerTest):
(GLibAPITestRunnerTest.setUp):
(GLibAPITestRunnerTest.tearDown):
(GLibAPITestRunnerTest._create_executable):
(GLibAPITestRunnerTest.test_resolves_bare_and_prefixed_binary_names):
(GLibAPITestRunnerTest.test_canonical_and_prefixed_names_select_the_same_glib_subtest):
(GLibAPITestRunnerTest.test_canonical_google_test_name_resolves_and_selects_only_its_test_case):
(GLibAPITestRunnerTest.test_multiple_subtests_are_preserved):
(GLibAPITestRunnerTest.test_uploaded_names_can_be_passed_back_to_the_runner):
(GLibAPITestRunnerTest.test_json_output_uses_uploaded_test_names):
* Tools/glib/api_test_runner.py:
(TestRunner._resolve_test_program): Added.
(TestRunner._get_tests):
(TestRunner._generate_test_list_for_json_output): Added.
(TestRunner._canonical_binary_name): Added.
(TestRunner._getsubtests_to_run_for_test):
(TestRunner.run_tests):
(TestRunner.run_tests.generate_test_list_for_json_output): Deleted.
Canonical link: https://commits.webkit.org/318146@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
